Make CanResize and CanMaximize depend on shape (WidgetHasHitTestMask).

Make CanResize and CanMaximize depend on shape (WidgetHasHitTestMask).

This makes windows with a shape implicitly non-resizable and
non-maximizable.

BUG=408737
Committed: https://crrev.com/e163ac2ad78d8047bcae08d581d5921e5685f086
Cr-Commit-Position: refs/heads/master@{#294563}

[jackhou1, 2014-09-12 01:22:50]

jackhou@chromium.org changed reviewers:
+ tapted@chromium.org

[jackhou1, 2014-09-12 01:22:51]

tapted, could you please review?

Summary of bug: a window with a shape can be dragged to edge of screen causing
window manager to maximize it. This should be prevented if CanMaximize or
CanResize is false. (Actually, it doesn't yet, I'm fixing it on CrOS and
Windows).

[tapted, 2014-09-12 01:51:42]

Does ChromeNativeAppWindowViews::UpdateShape need to call
widget()->OnSizeConstraintsChanged(); ?

Maybe it would be nicer for UpdateShape to call (a new function)
NativeAppWindowViews::SetResizable(..)  [which also calls
widget_->OnSizeConstraintsChanged()]

[jackhou1, 2014-09-12 06:28:07]

On 2014/09/12 01:51:42, tapted wrote:
> Does ChromeNativeAppWindowViews::UpdateShape need to call
> widget()->OnSizeConstraintsChanged(); ?

Oh yes, good catch.

> Maybe it would be nicer for UpdateShape to call (a new function)
> NativeAppWindowViews::SetResizable(..)  [which also calls
> widget_->OnSizeConstraintsChanged()]

In future I want allow apps to change resizable. So we need to keep track of
whether an app set resizable:false, or if the window is non-resizable for other
reasons.

[tapted, 2014-09-12 07:33:57]

lgtm

[jackhou1, 2014-09-12 07:42:31]

The CQ bit was checked by jackhou@chromium.org

[commit-bot: I haz the power, 2014-09-12 07:42:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/552313003/20001

[commit-bot: I haz the power, 2014-09-12 09:46:27]

Committed patchset #2 (id:20001) as 10ec7606e29e21eeb6415d3fae4fa16d139f1018

[commit-bot: I haz the power, 2014-09-12 09:48:46]

Patchset 2 (id:??) landed as
https://crrev.com/e163ac2ad78d8047bcae08d581d5921e5685f086
Cr-Commit-Position: refs/heads/master@{#294563}