LayoutTests/media/gc-while-playing.html - Issue 552303006: Prevent more script-observable cases of HTMLMediaElement GC

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/media/gc-while-playing.html

Issue 552303006: Prevent more script-observable cases of HTMLMediaElement GC (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: cleanup Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <title>GC while playing</title>

	3 <script src="../resources/testharness.js"></script>

	4 <script src="../resources/testharnessreport.js"></script>

	5 <script src="media-file.js"></script>

	6 <script>

	7 async_test(function(t)

	8 {

	9 var a = document.createElement("audio");

	10 a.foo = "bar";

	11 a.src = findMediaFile("audio", "content/test");

	12 a.onsuspend = t.step_func(function()

	13 {

	14 assert_equals(a.networkState, a.NETWORK_IDLE);

	15 a.play();

	16 // GC async since the event target is the media element.

	17 setTimeout(t.step_func(gcAndAwaitTimeupdate), 0);
	acolwell GONE FROM CHROMIUM 2014/09/12 16:27:25 Isn't the reference to 'a' in gcAndAwaitTimeupdate Isn't the reference to 'a' in gcAndAwaitTimeupdate() also keeping the media element around? Please fix the comment or code so that they are consistent. philipj_slow 2014/09/12 19:13:00 I've updated the comments to be accurate, hopefull Show quoted text On 2014/09/12 16:27:25, acolwell_leaving_chromium_9-23 wrote: > Isn't the reference to 'a' in gcAndAwaitTimeupdate() also keeping the media > element around? Please fix the comment or code so that they are consistent. I've updated the comments to be accurate, hopefully.
	18 });

	19 function gcAndAwaitTimeupdate()

	20 {

	21 a.ontimeupdate = t.step_func(function(e)

	22 {

	23 assert_greater_than(e.target.currentTime, 0);

	24 assert_equals(e.target.foo, "bar");

	25 t.done();

	26 });

	27 a = null;

	28 gc();

	29 }

	30 });

	31 </script>

OLD	NEW