Fix StoreIndexedInstr input representation requirements for Int32/Uint32 arrays.

runtime/vm/assembler_arm.h

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef VM_ASSEMBLER_ARM_H_
 #define VM_ASSEMBLER_ARM_H_
 
 #ifndef VM_ASSEMBLER_H_
 #error Do not include assembler_arm.h directly; use assembler.h instead.
 #endif
@@ skipping 699 matching lines @@
   void MoveRegister(Register rd, Register rm, Condition cond = AL);
 
   // Convenience shift instructions. Use mov instruction with shifter operand
   // for variants setting the status flags.
   void Lsl(Register rd, Register rm, uint32_t shift_imm, Condition cond = AL);
   void Lsl(Register rd, Register rm, Register rs, Condition cond = AL);
   void Lsr(Register rd, Register rm, uint32_t shift_imm, Condition cond = AL);
   void Lsr(Register rd, Register rm, Register rs, Condition cond = AL);
   void Asr(Register rd, Register rm, uint32_t shift_imm, Condition cond = AL);
   void Asr(Register rd, Register rm, Register rs, Condition cond = AL);
+  void AsrS(Register rd, Register rm, uint32_t shift_imm, Condition cond = AL);

[zra, 2014/09/10 23:17:22]

It looks like we've been using a little s, i.e. Asrs, to indicate the version of
an instruction that sets condition codes.

[Vyacheslav Egorov (Google), 2014/09/11 11:49:16]

Done.

   void Ror(Register rd, Register rm, uint32_t shift_imm, Condition cond = AL);
   void Ror(Register rd, Register rm, Register rs, Condition cond = AL);
   void Rrx(Register rd, Register rm, Condition cond = AL);
 
   // Fill rd with the sign of rm.
   void SignFill(Register rd, Register rm, Condition cond = AL);
 
   void Vreciprocalqs(QRegister qd, QRegister qm);
   void VreciprocalSqrtqs(QRegister qd, QRegister qm);
   // If qm must be preserved, then provide a (non-QTMP) temporary.
   void Vsqrtqs(QRegister qd, QRegister qm, QRegister temp);
   void Vdivqs(QRegister qd, QRegister qn, QRegister qm);
 
   void SmiTag(Register reg, Condition cond = AL) {
     Lsl(reg, reg, kSmiTagSize, cond);
   }
 
+  void SmiTag(Register dst, Register src, Condition cond = AL) {
+    Lsl(dst, src, kSmiTagSize, cond);
+  }
+
   void SmiUntag(Register reg, Condition cond = AL) {
     Asr(reg, reg, kSmiTagSize, cond);
   }
 
   void SmiUntag(Register dst, Register src, Condition cond = AL) {
     Asr(dst, src, kSmiTagSize, cond);
   }
 
+  void SmiUntag(Register dst, Register src, Label* ok) {

[zra, 2014/09/10 23:17:22]

Maybe comment here about what the Label is for.

[Vyacheslav Egorov (Google), 2014/09/11 11:49:16]

Done.

+    ASSERT(kSmiTagSize == 1);
+    AsrS(dst, src, kSmiTagSize);
+    b(ok, CC);
+  }
+
   // Function frame setup and tear down.
   void EnterFrame(RegList regs, intptr_t frame_space);
   void LeaveFrame(RegList regs);
   void Ret();
   void ReserveAlignedFrameSpace(intptr_t frame_space);
 
   // Create a frame for calling into runtime that preserves all volatile
   // registers.  Frame's SP is guaranteed to be correctly aligned and
   // frame_space bytes are reserved under it.
   void EnterCallRuntimeFrame(intptr_t frame_space);
@@ skipping 211 matching lines @@
                                   Register value,
                                   Label* no_update);
 
   DISALLOW_ALLOCATION();
   DISALLOW_COPY_AND_ASSIGN(Assembler);
 };
 
 }  // namespace dart
 
 #endif  // VM_ASSEMBLER_ARM_H_