Issue 552303004: Distinguish common and unique names for skiaperf.com.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 552303004: Distinguish common and unique names for skiaperf.com. (Closed)

Created:
6 years, 3 months ago by mtklein_C

Modified:
6 years, 3 months ago

Reviewers:
jcgregorio, mtklein

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

Distinguish common and unique names for skiaperf.com. Turns out we tack on the size post-facto in ResultsWriter::bench(), so the only place we need getUniqueName() to differ from getName() is SKPBench. BUG=skia: Committed: https://skia.googlesource.com/skia/+/962890568ddac03d8eb8467a2e81b6f2b7f046f0

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -10 lines)			Patch
M	bench/Benchmark.h	View	1	2 chunks	+2 lines, -0 lines	0 comments	Download
M	bench/Benchmark.cpp	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	bench/SKPBench.h	View	1	2 chunks	+2 lines, -0 lines	0 comments	Download
M	bench/SKPBench.cpp	View	1	1 chunk	+7 lines, -2 lines	0 comments	Download
M	bench/nanobench.cpp	View	1	7 chunks	+9 lines, -8 lines	0 comments	Download

Total messages: 6 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/552303004/20001

6 years, 3 months ago (2014-09-10 18:58:12 UTC) #5

commit-bot: I haz the power

6 years, 3 months ago (2014-09-10 19:06:03 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 (id:20001) as 962890568ddac03d8eb8467a2e81b6f2b7f046f0