Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 552283003: Move request_stage.* to extensions/browser/api/declarative_webrequest. (Closed)

Created:
6 years, 3 months ago by wjmaclean
Modified:
6 years, 3 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, Fady Samuel, Xi Han, lfg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Move request_stage.* to extensions/browser/api/declarative_webrequest. BUG=352293 Committed: https://crrev.com/b1d9fb8b4eda087fe437999c93dd908400f3f4d3 Cr-Commit-Position: refs/heads/master@{#294079}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -82 lines) Patch
D chrome/browser/extensions/api/declarative_webrequest/request_stage.h View 1 chunk +0 lines, -36 lines 0 comments Download
D chrome/browser/extensions/api/declarative_webrequest/request_stage.cc View 1 chunk +0 lines, -30 lines 0 comments Download
M chrome/browser/extensions/api/declarative_webrequest/webrequest_action.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/declarative_webrequest/webrequest_action.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/declarative_webrequest/webrequest_action_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/declarative_webrequest/webrequest_condition.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/declarative_webrequest/webrequest_condition_attribute.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/declarative_webrequest/webrequest_condition_attribute.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/web_request/web_request_api.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/web_request/web_request_api.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/chrome_browser_extensions.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M extensions/browser/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
A + extensions/browser/api/declarative_webrequest/request_stage.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + extensions/browser/api/declarative_webrequest/request_stage.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/extensions.gyp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
wjmaclean
Simple move, please take a look?
6 years, 3 months ago (2014-09-09 16:33:54 UTC) #2
Ken Rockot(use gerrit already)
lgtm
6 years, 3 months ago (2014-09-09 23:22:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wjmaclean@chromium.org/552283003/1
6 years, 3 months ago (2014-09-09 23:52:15 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 871a9156b652aa7f19b620db9782af271e63f508
6 years, 3 months ago (2014-09-10 02:32:28 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:58:23 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/b1d9fb8b4eda087fe437999c93dd908400f3f4d3
Cr-Commit-Position: refs/heads/master@{#294079}

Powered by Google App Engine
This is Rietveld 408576698