Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 552273004: Remove implicit conversions from scoped_refptr to T* in content/common/gpu (Closed)

Created:
6 years, 3 months ago by dcheng
Modified:
6 years, 3 months ago
Reviewers:
xhwang
CC:
chromium-reviews, darin-cc_chromium.org, feature-media-reviews_chromium.org, jam, mcasas+watch_chromium.org, piman+watch_chromium.org, posciak+watch_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove implicit conversions from scoped_refptr to T* in content/common/gpu This patch was generated by running the rewrite_scoped_refptr clang tool on a ChromeOS build. BUG=110610 Committed: https://crrev.com/e68b03e9002692d85a3b6c18130806e3b02dfb2f Cr-Commit-Position: refs/heads/master@{#294893}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M content/common/gpu/media/rendering_helper.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
dcheng
Some background: Unfortunately, we can't make scoped_refptr testable until the conversion operator has been removed. ...
6 years, 3 months ago (2014-09-15 20:05:36 UTC) #2
xhwang
lgtm
6 years, 3 months ago (2014-09-15 20:11:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/552273004/1
6 years, 3 months ago (2014-09-15 20:24:10 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 6709513bfc50d8e87e867e69c3e149945a468475
6 years, 3 months ago (2014-09-15 21:25:56 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-15 21:31:17 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e68b03e9002692d85a3b6c18130806e3b02dfb2f
Cr-Commit-Position: refs/heads/master@{#294893}

Powered by Google App Engine
This is Rietveld 408576698