Implement ToLength from ES6 section 7.1.15

Implement ToLength from ES6 section 7.1.15

BUG=
R=rossberg@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=24036

[caitp (gmail), 2014-09-09 12:47:21]

caitpotter88@gmail.com changed reviewers:
+ aperez@igalia.com, dpino@igalia.com

[caitp (gmail), 2014-09-09 12:48:15]

Here's a minimal one

[caitp (gmail), 2014-09-09 17:31:07]

Right, I was asked to submit this at https://codereview.chromium.org/553623004/

[caitp (gmail), 2014-09-09 17:31:26]

caitpotter88@gmail.com changed reviewers:
+ rossberg@chromium.org

[aperez, 2014-09-10 07:18:24]

On 2014/09/09 12:48:15, caitp wrote:
> Here's a minimal one

I think it would be good to use this CL to also change usage of ToUint32(), and
use ToLength() instead where appropriate. You can take the places where this
change should be from the CL at https://codereview.chromium.org/553623004/

[rossberg, 2014-09-10 07:29:51]

https://codereview.chromium.org/552273002/diff/1/src/runtime.js
File src/runtime.js (right):

https://codereview.chromium.org/552273002/diff/1/src/runtime.js#newcode594
src/runtime.js:594: // ES6, draft 08-24-14, section 7.1.15
Nit: move this next to ToInteger

https://codereview.chromium.org/552273002/diff/1/src/runtime.js#newcode597
src/runtime.js:597: if (arg < +0) return 0;
Nit: remove the +

[caitp (gmail), 2014-09-10 11:49:40]

On 2014/09/10 07:18:24, aperez wrote:
> On 2014/09/09 12:48:15, caitp wrote:
> > Here's a minimal one
> 
> I think it would be good to use this CL to also change usage of ToUint32(),
and
> use ToLength() instead where appropriate. You can take the places where this
> change should be from the CL at https://codereview.chromium.org/553623004/

Since you've already got a CL for that, it might be better to just use yours for
that (just removing the native implementation of ToLength)

https://codereview.chromium.org/552273002/diff/1/src/runtime.js
File src/runtime.js (right):

https://codereview.chromium.org/552273002/diff/1/src/runtime.js#newcode594
src/runtime.js:594: // ES6, draft 08-24-14, section 7.1.15
On 2014/09/10 07:29:51, rossberg wrote:
> Nit: move this next to ToInteger

Acknowledged.

https://codereview.chromium.org/552273002/diff/1/src/runtime.js#newcode597
src/runtime.js:597: if (arg < +0) return 0;
On 2014/09/10 07:29:51, rossberg wrote:
> Nit: remove the +

Acknowledged.

[caitp (gmail), 2014-09-17 16:33:50]

On 2014/09/10 11:49:40, caitp wrote:
> On 2014/09/10 07:18:24, aperez wrote:
> > On 2014/09/09 12:48:15, caitp wrote:
> > > Here's a minimal one
> > 
> > I think it would be good to use this CL to also change usage of ToUint32(),
> and
> > use ToLength() instead where appropriate. You can take the places where this
> > change should be from the CL at https://codereview.chromium.org/553623004/
> 
> Since you've already got a CL for that, it might be better to just use yours
for
> that (just removing the native implementation of ToLength)
> 
> https://codereview.chromium.org/552273002/diff/1/src/runtime.js
> File src/runtime.js (right):
> 
> https://codereview.chromium.org/552273002/diff/1/src/runtime.js#newcode594
> src/runtime.js:594: // ES6, draft 08-24-14, section 7.1.15
> On 2014/09/10 07:29:51, rossberg wrote:
> > Nit: move this next to ToInteger
> 
> Acknowledged.
> 
> https://codereview.chromium.org/552273002/diff/1/src/runtime.js#newcode597
> src/runtime.js:597: if (arg < +0) return 0;
> On 2014/09/10 07:29:51, rossberg wrote:
> > Nit: remove the +
> 
> Acknowledged.

Is there anything else needed here? It's a pretty simple one

[rossberg, 2014-09-18 12:07:52]

LGTM, will land

[rossberg, 2014-09-18 12:21:59]

Committed patchset #2 manually as 24036 (presubmit successful).