Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: src/x87/full-codegen-x87.cc

Issue 552253003: Revert "Change the order of arguments of the (One|Two)ByteSeqStringSetChar intrinsic." (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/x64/full-codegen-x64.cc ('k') | test/mjsunit/lithium/SeqStringSetChar.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_X87 7 #if V8_TARGET_ARCH_X87
8 8
9 #include "src/code-factory.h" 9 #include "src/code-factory.h"
10 #include "src/code-stubs.h" 10 #include "src/code-stubs.h"
(...skipping 3338 matching lines...) Expand 10 before | Expand all | Expand 10 after
3349 3349
3350 3350
3351 void FullCodeGenerator::EmitOneByteSeqStringSetChar(CallRuntime* expr) { 3351 void FullCodeGenerator::EmitOneByteSeqStringSetChar(CallRuntime* expr) {
3352 ZoneList<Expression*>* args = expr->arguments(); 3352 ZoneList<Expression*>* args = expr->arguments();
3353 DCHECK_EQ(3, args->length()); 3353 DCHECK_EQ(3, args->length());
3354 3354
3355 Register string = eax; 3355 Register string = eax;
3356 Register index = ebx; 3356 Register index = ebx;
3357 Register value = ecx; 3357 Register value = ecx;
3358 3358
3359 VisitForStackValue(args->at(0)); // index 3359 VisitForStackValue(args->at(1)); // index
3360 VisitForStackValue(args->at(1)); // value 3360 VisitForStackValue(args->at(2)); // value
3361 VisitForAccumulatorValue(args->at(2)); // string 3361 VisitForAccumulatorValue(args->at(0)); // string
3362 3362
3363 __ pop(value); 3363 __ pop(value);
3364 __ pop(index); 3364 __ pop(index);
3365 3365
3366 if (FLAG_debug_code) { 3366 if (FLAG_debug_code) {
3367 __ test(value, Immediate(kSmiTagMask)); 3367 __ test(value, Immediate(kSmiTagMask));
3368 __ Check(zero, kNonSmiValue); 3368 __ Check(zero, kNonSmiValue);
3369 __ test(index, Immediate(kSmiTagMask)); 3369 __ test(index, Immediate(kSmiTagMask));
3370 __ Check(zero, kNonSmiValue); 3370 __ Check(zero, kNonSmiValue);
3371 } 3371 }
(...skipping 13 matching lines...) Expand all
3385 3385
3386 3386
3387 void FullCodeGenerator::EmitTwoByteSeqStringSetChar(CallRuntime* expr) { 3387 void FullCodeGenerator::EmitTwoByteSeqStringSetChar(CallRuntime* expr) {
3388 ZoneList<Expression*>* args = expr->arguments(); 3388 ZoneList<Expression*>* args = expr->arguments();
3389 DCHECK_EQ(3, args->length()); 3389 DCHECK_EQ(3, args->length());
3390 3390
3391 Register string = eax; 3391 Register string = eax;
3392 Register index = ebx; 3392 Register index = ebx;
3393 Register value = ecx; 3393 Register value = ecx;
3394 3394
3395 VisitForStackValue(args->at(0)); // index 3395 VisitForStackValue(args->at(1)); // index
3396 VisitForStackValue(args->at(1)); // value 3396 VisitForStackValue(args->at(2)); // value
3397 VisitForAccumulatorValue(args->at(2)); // string 3397 VisitForAccumulatorValue(args->at(0)); // string
3398 __ pop(value); 3398 __ pop(value);
3399 __ pop(index); 3399 __ pop(index);
3400 3400
3401 if (FLAG_debug_code) { 3401 if (FLAG_debug_code) {
3402 __ test(value, Immediate(kSmiTagMask)); 3402 __ test(value, Immediate(kSmiTagMask));
3403 __ Check(zero, kNonSmiValue); 3403 __ Check(zero, kNonSmiValue);
3404 __ test(index, Immediate(kSmiTagMask)); 3404 __ test(index, Immediate(kSmiTagMask));
3405 __ Check(zero, kNonSmiValue); 3405 __ Check(zero, kNonSmiValue);
3406 __ SmiUntag(index); 3406 __ SmiUntag(index);
3407 static const uint32_t two_byte_seq_type = kSeqStringTag | kTwoByteStringTag; 3407 static const uint32_t two_byte_seq_type = kSeqStringTag | kTwoByteStringTag;
(...skipping 1408 matching lines...) Expand 10 before | Expand all | Expand 10 after
4816 DCHECK_EQ(isolate->builtins()->OsrAfterStackCheck()->entry(), 4816 DCHECK_EQ(isolate->builtins()->OsrAfterStackCheck()->entry(),
4817 Assembler::target_address_at(call_target_address, 4817 Assembler::target_address_at(call_target_address,
4818 unoptimized_code)); 4818 unoptimized_code));
4819 return OSR_AFTER_STACK_CHECK; 4819 return OSR_AFTER_STACK_CHECK;
4820 } 4820 }
4821 4821
4822 4822
4823 } } // namespace v8::internal 4823 } } // namespace v8::internal
4824 4824
4825 #endif // V8_TARGET_ARCH_X87 4825 #endif // V8_TARGET_ARCH_X87
OLDNEW
« no previous file with comments | « src/x64/full-codegen-x64.cc ('k') | test/mjsunit/lithium/SeqStringSetChar.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698