Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Side by Side Diff: src/mips64/full-codegen-mips64.cc

Issue 552253003: Revert "Change the order of arguments of the (One|Two)ByteSeqStringSetChar intrinsic." (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/mips/full-codegen-mips.cc ('k') | src/runtime.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_MIPS64 7 #if V8_TARGET_ARCH_MIPS64
8 8
9 // Note on Mips implementation: 9 // Note on Mips implementation:
10 // 10 //
(...skipping 3416 matching lines...) Expand 10 before | Expand all | Expand 10 after
3427 3427
3428 3428
3429 void FullCodeGenerator::EmitOneByteSeqStringSetChar(CallRuntime* expr) { 3429 void FullCodeGenerator::EmitOneByteSeqStringSetChar(CallRuntime* expr) {
3430 ZoneList<Expression*>* args = expr->arguments(); 3430 ZoneList<Expression*>* args = expr->arguments();
3431 DCHECK_EQ(3, args->length()); 3431 DCHECK_EQ(3, args->length());
3432 3432
3433 Register string = v0; 3433 Register string = v0;
3434 Register index = a1; 3434 Register index = a1;
3435 Register value = a2; 3435 Register value = a2;
3436 3436
3437 VisitForStackValue(args->at(0)); // index 3437 VisitForStackValue(args->at(1)); // index
3438 VisitForStackValue(args->at(1)); // value 3438 VisitForStackValue(args->at(2)); // value
3439 VisitForAccumulatorValue(args->at(2)); // string 3439 VisitForAccumulatorValue(args->at(0)); // string
3440 __ Pop(index, value); 3440 __ Pop(index, value);
3441 3441
3442 if (FLAG_debug_code) { 3442 if (FLAG_debug_code) {
3443 __ SmiTst(value, at); 3443 __ SmiTst(value, at);
3444 __ Check(eq, kNonSmiValue, at, Operand(zero_reg)); 3444 __ Check(eq, kNonSmiValue, at, Operand(zero_reg));
3445 __ SmiTst(index, at); 3445 __ SmiTst(index, at);
3446 __ Check(eq, kNonSmiIndex, at, Operand(zero_reg)); 3446 __ Check(eq, kNonSmiIndex, at, Operand(zero_reg));
3447 __ SmiUntag(index, index); 3447 __ SmiUntag(index, index);
3448 static const uint32_t one_byte_seq_type = kSeqStringTag | kOneByteStringTag; 3448 static const uint32_t one_byte_seq_type = kSeqStringTag | kOneByteStringTag;
3449 Register scratch = t1; 3449 Register scratch = t1;
(...skipping 14 matching lines...) Expand all
3464 3464
3465 3465
3466 void FullCodeGenerator::EmitTwoByteSeqStringSetChar(CallRuntime* expr) { 3466 void FullCodeGenerator::EmitTwoByteSeqStringSetChar(CallRuntime* expr) {
3467 ZoneList<Expression*>* args = expr->arguments(); 3467 ZoneList<Expression*>* args = expr->arguments();
3468 DCHECK_EQ(3, args->length()); 3468 DCHECK_EQ(3, args->length());
3469 3469
3470 Register string = v0; 3470 Register string = v0;
3471 Register index = a1; 3471 Register index = a1;
3472 Register value = a2; 3472 Register value = a2;
3473 3473
3474 VisitForStackValue(args->at(0)); // index 3474 VisitForStackValue(args->at(1)); // index
3475 VisitForStackValue(args->at(1)); // value 3475 VisitForStackValue(args->at(2)); // value
3476 VisitForAccumulatorValue(args->at(2)); // string 3476 VisitForAccumulatorValue(args->at(0)); // string
3477 __ Pop(index, value); 3477 __ Pop(index, value);
3478 3478
3479 if (FLAG_debug_code) { 3479 if (FLAG_debug_code) {
3480 __ SmiTst(value, at); 3480 __ SmiTst(value, at);
3481 __ Check(eq, kNonSmiValue, at, Operand(zero_reg)); 3481 __ Check(eq, kNonSmiValue, at, Operand(zero_reg));
3482 __ SmiTst(index, at); 3482 __ SmiTst(index, at);
3483 __ Check(eq, kNonSmiIndex, at, Operand(zero_reg)); 3483 __ Check(eq, kNonSmiIndex, at, Operand(zero_reg));
3484 __ SmiUntag(index, index); 3484 __ SmiUntag(index, index);
3485 static const uint32_t two_byte_seq_type = kSeqStringTag | kTwoByteStringTag; 3485 static const uint32_t two_byte_seq_type = kSeqStringTag | kTwoByteStringTag;
3486 Register scratch = t1; 3486 Register scratch = t1;
(...skipping 1389 matching lines...) Expand 10 before | Expand all | Expand 10 after
4876 Assembler::target_address_at(pc_immediate_load_address)) == 4876 Assembler::target_address_at(pc_immediate_load_address)) ==
4877 reinterpret_cast<uint64_t>( 4877 reinterpret_cast<uint64_t>(
4878 isolate->builtins()->OsrAfterStackCheck()->entry())); 4878 isolate->builtins()->OsrAfterStackCheck()->entry()));
4879 return OSR_AFTER_STACK_CHECK; 4879 return OSR_AFTER_STACK_CHECK;
4880 } 4880 }
4881 4881
4882 4882
4883 } } // namespace v8::internal 4883 } } // namespace v8::internal
4884 4884
4885 #endif // V8_TARGET_ARCH_MIPS64 4885 #endif // V8_TARGET_ARCH_MIPS64
OLDNEW
« no previous file with comments | « src/mips/full-codegen-mips.cc ('k') | src/runtime.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698