Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issue 552243002: Handle non-object constants in HConstant::GetMonomorphicJSObjectMap. (Closed)

Created:
6 years, 3 months ago by Jarin
Modified:
6 years, 3 months ago
Reviewers:
ulan
CC:
v8-dev, Toon Verwaest
Project:
v8
Visibility:
Public.

Description

Handle non-object constants in HConstant::GetMonomorphicJSObjectMap. R=ulan@chromium.org BUG=chromium:412162 LOG=N Committed: https://code.google.com/p/v8/source/detail?r=23803

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M src/hydrogen-instructions.h View 1 chunk +1 line, -1 line 0 comments Download
A + test/mjsunit/regress/regress-412162.js View 1 chunk +6 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Jarin
Could you take a look, please? I think there is a better fix (number constants ...
6 years, 3 months ago (2014-09-09 09:49:03 UTC) #2
ulan
lgtm, thanks!
6 years, 3 months ago (2014-09-09 09:51:09 UTC) #3
Jarin
6 years, 3 months ago (2014-09-09 12:58:45 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 23803 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698