Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issue 552203002: Rename gyp variable use_titlecase_in_grd_files -> use_titlecase_in_grd (Closed)

Created:
6 years, 3 months ago by joleksy
Modified:
6 years, 3 months ago
Reviewers:
Mark Mentovai, nilesh
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Rename gyp variable use_titlecase_in_grd_files -> use_titlecase_in_grd See tools/gyp/pylib/gyp/input.py: "Sections mathing the regexp '_(dir|file|path)s?$' are also considered PathSections." Standard gyp variables should not be named like this. BUG= Committed: https://crrev.com/a91e86837e8af810c14543eb01851b7881ff95d8 Cr-Commit-Position: refs/heads/master@{#294166}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M build/common.gypi View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
joleksy
@reviewer: does it look ok to you?
6 years, 3 months ago (2014-09-09 07:58:15 UTC) #2
Mark Mentovai
LGTM
6 years, 3 months ago (2014-09-09 13:05:39 UTC) #4
joleksy
On 2014/09/09 13:05:39, Mark Mentovai wrote: > LGTM I created also related Breakpad patch: https://breakpad.appspot.com/5694002/
6 years, 3 months ago (2014-09-10 07:01:52 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joleksy@opera.com/552203002/1
6 years, 3 months ago (2014-09-10 12:49:30 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as 5aa1e7f3a8e746762a8c9441b370d68f7216ffd8
6 years, 3 months ago (2014-09-10 13:50:58 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 13:53:31 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a91e86837e8af810c14543eb01851b7881ff95d8
Cr-Commit-Position: refs/heads/master@{#294166}

Powered by Google App Engine
This is Rietveld 408576698