NaCl: Use RAII for sockets in NaClProcessHost.

NaCl: Use RAII for sockets in NaClProcessHost.

According to crbug.com/412186, there is some incorrect handle management in
NaClProcessHost. It's much easier to use base::File to manage closing the
socket handles, and it cleans up some weirdness with directly using NaClHandle
as well.

BUG=412186
Committed: https://crrev.com/296f9f1355e119d78beb1ce377126010c14886d9
Cr-Commit-Position: refs/heads/master@{#294511}

[teravest, 2014-09-11 20:01:15]

teravest@chromium.org changed reviewers:
+ mseaborn@chromium.org

[Mark Seaborn, 2014-09-11 20:43:26]

The main change is OK.  I'm not so keen on the incidental change.

https://codereview.chromium.org/552183004/diff/30001/components/nacl/browser/...
File components/nacl/browser/nacl_process_host.cc (right):

https://codereview.chromium.org/552183004/diff/30001/components/nacl/browser/...
components/nacl/browser/nacl_process_host.cc:147: #endif  // defined(OS_WIN)
Having #if/#endif nesting not nest with namespace{} is quite confusing.

[teravest, 2014-09-11 21:41:56]

On 2014/09/11 20:43:26, Mark Seaborn wrote:
> The main change is OK.  I'm not so keen on the incidental change.
> 
>
https://codereview.chromium.org/552183004/diff/30001/components/nacl/browser/...
> File components/nacl/browser/nacl_process_host.cc (right):
> 
>
https://codereview.chromium.org/552183004/diff/30001/components/nacl/browser/...
> components/nacl/browser/nacl_process_host.cc:147: #endif  // defined(OS_WIN)
> Having #if/#endif nesting not nest with namespace{} is quite confusing.

Fair enough. The nesting should be better a bit better now, I think. Let me know
if you still don't like this, and I can put the namespaces back the way they
were.

[Mark Seaborn, 2014-09-11 21:50:04]

LGTM, thanks

[teravest, 2014-09-11 22:05:00]

The CQ bit was checked by teravest@chromium.org

[commit-bot: I haz the power, 2014-09-11 22:23:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/552183004/70001

[commit-bot: I haz the power, 2014-09-12 00:56:00]

Committed patchset #5 (id:70001) as ef8e0e34617a21d49fd4da969a6fa22de84c6ed6

[commit-bot: I haz the power, 2014-09-12 00:57:41]

Patchset 5 (id:??) landed as
https://crrev.com/296f9f1355e119d78beb1ce377126010c14886d9
Cr-Commit-Position: refs/heads/master@{#294511}