Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issue 552163002: AX: Calendar Picker: Add AX labels to MonthPopupButton and CalendarNavigationButtons. (Closed)

Created:
6 years, 3 months ago by tkent
Modified:
6 years, 3 months ago
Reviewers:
keishi
CC:
blink-reviews, jamesr, dglazkov+blink, abarth-chromium
Project:
blink
Visibility:
Public.

Description

AX: Calendar Picker: Add AX labels to MonthPopupButton and CalendarNavigationButtons. This CL adds no new tests. Will add tests after a Chromium change for string resource. BUG=123896 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181617

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -1 line) Patch
M ManualTests/forms/calendar-picker.html View 1 chunk +5 lines, -1 line 0 comments Download
M Source/web/DateTimeChooserImpl.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/web/resources/calendarPicker.js View 4 chunks +4 lines, -0 lines 0 comments Download
M public/platform/WebLocalizedString.h View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
tkent
Please review this.
6 years, 3 months ago (2014-09-09 06:37:37 UTC) #2
keishi
lgtm
6 years, 3 months ago (2014-09-09 07:41:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/552163002/1
6 years, 3 months ago (2014-09-09 07:42:09 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-09-09 07:55:19 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 181617

Powered by Google App Engine
This is Rietveld 408576698