Adds AppListServiceImplBrowserTest.ShowLoadedProfiles

Adds AppListServiceImplBrowserTest.ShowLoadedProfiles

Currently there is only AppListServiceInteractiveTest which is excessive
for tests that do not need to be interactive. It also leaves gaps in the
testing of the AppListServiceImpl, since it only uses the parent,
AppListService interface.

This CL adds scaffolding for better app list test coverage, leading up
to better testing for Chrome's AppListViewDelegate, which is currently
hard to get at in a test.

The test is a non-interactive version of showing the app list, which
verifies expectations about the actual Profile* that is missing from
current tests (e.g. TestingAppListServiceImpl has it mocked out to
return NULL, since unit_tests don't have a ProfileManager).

BUG=169114
Committed: https://crrev.com/761b2a4cbc3103ef5e48cc7e77184f57eb50f6d4
Cr-Commit-Position: refs/heads/master@{#294138}

[tapted, 2014-09-10 01:56:33]

tapted@chromium.org changed reviewers:
+ calamity@chromium.org

[tapted, 2014-09-10 01:56:34]

Hi calamity - please take a look. This is split off from the monster patch
trying to move the AppListViewDelegate ownership in crrev/508813002, and leads
up to actually testing Chrome's AppListViewDelegate ( :o !) which is impossible
to get at in tests.

[calamity, 2014-09-10 06:18:24]

lgtm w/ nits.

https://codereview.chromium.org/552153002/diff/40001/chrome/browser/ui/app_li...
File chrome/browser/ui/app_list/app_list_service_impl_browsertest.cc (right):

https://codereview.chromium.org/552153002/diff/40001/chrome/browser/ui/app_li...
chrome/browser/ui/app_list/app_list_service_impl_browsertest.cc:53: //
synchronous. Then tests that showing a second loaded profile without without
s/without without/without/

https://codereview.chromium.org/552153002/diff/40001/chrome/browser/ui/app_li...
File chrome/browser/ui/app_list/test/chrome_app_list_test_support.h (right):

https://codereview.chromium.org/552153002/diff/40001/chrome/browser/ui/app_li...
chrome/browser/ui/app_list/test/chrome_app_list_test_support.h:14: class
AppListViewDelegate;
Don't need this.

[tapted, 2014-09-10 06:24:24]

https://codereview.chromium.org/552153002/diff/40001/chrome/browser/ui/app_li...
File chrome/browser/ui/app_list/app_list_service_impl_browsertest.cc (right):

https://codereview.chromium.org/552153002/diff/40001/chrome/browser/ui/app_li...
chrome/browser/ui/app_list/app_list_service_impl_browsertest.cc:53: //
synchronous. Then tests that showing a second loaded profile without without
On 2014/09/10 06:18:24, calamity wrote:
> s/without without/without/

Done.

https://codereview.chromium.org/552153002/diff/40001/chrome/browser/ui/app_li...
File chrome/browser/ui/app_list/test/chrome_app_list_test_support.h (right):

https://codereview.chromium.org/552153002/diff/40001/chrome/browser/ui/app_li...
chrome/browser/ui/app_list/test/chrome_app_list_test_support.h:14: class
AppListViewDelegate;
On 2014/09/10 06:18:24, calamity wrote:
> Don't need this.

Done.

[tapted, 2014-09-10 06:24:29]

The CQ bit was checked by tapted@chromium.org

[commit-bot: I haz the power, 2014-09-10 06:24:56]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tapted@chromium.org/552153002/60001

[commit-bot: I haz the power, 2014-09-10 07:58:53]

Committed patchset #4 (id:60001) as 09bd44847eec8a378cbab9d62de0272334a78126

[commit-bot: I haz the power, 2014-09-10 08:08:21]

Patchset 4 (id:??) landed as
https://crrev.com/761b2a4cbc3103ef5e48cc7e77184f57eb50f6d4
Cr-Commit-Position: refs/heads/master@{#294138}