Source/bindings/tests/results/core/V8TestInterface2.cpp - Issue 552143004: Simplify TONATIVE_*_EXCEPTIONSTATE* macros

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/tests/results/core/V8TestInterface2.cpp

Issue 552143004: Simplify TONATIVE_*_EXCEPTIONSTATE* macros (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@bindings-conversion-ExceptionState

Patch Set: rebased Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/bindings/tests/results/core/V8TestInterface.cpp ('k') | Source/bindings/tests/results/core/V8TestInterfaceConstructor4.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/tests/results/core/V8TestInterface2.cpp

diff --git a/Source/bindings/tests/results/core/V8TestInterface2.cpp b/Source/bindings/tests/results/core/V8TestInterface2.cpp

index 80af27d1b14fceeaef58f01f0ca8836c6c5629cd..f2cbb124df60ade87d3bd40d4dc1d7882d4861a0 100644

--- a/Source/bindings/tests/results/core/V8TestInterface2.cpp

+++ b/Source/bindings/tests/results/core/V8TestInterface2.cpp

@@ -47,8 +47,6 @@ static void itemMethod(const v8::FunctionCallbackInfo<v8::Value>& info)

TestInterface2* impl = V8TestInterface2::toImpl(info.Holder());

unsigned index;

{

- v8::TryCatch block;

- V8RethrowTryCatchScope rethrow(block);

TONATIVE_VOID_EXCEPTIONSTATE_INTERNAL(index, toUInt32(info[0], exceptionState), exceptionState);

}

RefPtr<TestInterfaceEmpty> result = impl->item(index, exceptionState);

@@ -78,8 +76,6 @@ static void setItemMethod(const v8::FunctionCallbackInfo<v8::Value>& info)

unsigned index;

V8StringResource<> value;

{

- v8::TryCatch block;

- V8RethrowTryCatchScope rethrow(block);

TONATIVE_VOID_EXCEPTIONSTATE_INTERNAL(index, toUInt32(info[0], exceptionState), exceptionState);

TOSTRING_VOID_INTERNAL(value, info[1]);

}

@@ -109,8 +105,6 @@ static void deleteItemMethod(const v8::FunctionCallbackInfo<v8::Value>& info)

TestInterface2* impl = V8TestInterface2::toImpl(info.Holder());

unsigned index;

{

- v8::TryCatch block;

- V8RethrowTryCatchScope rethrow(block);

TONATIVE_VOID_EXCEPTIONSTATE_INTERNAL(index, toUInt32(info[0], exceptionState), exceptionState);

}

bool result = impl->deleteItem(index, exceptionState);