Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 552143003: MIDIAccess::create(): add missing adoptRefCountedGarbageCollected(). (Closed)

Created:
6 years, 3 months ago by sof
Modified:
6 years, 3 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

MIDIAccess::create(): add missing adoptRefCountedGarbageCollected(). R=ager@chromium.org,haraken@chromium.org BUG=340522 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181653

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/modules/webmidi/MIDIAccess.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
sof
Please take a look.
6 years, 3 months ago (2014-09-09 13:04:55 UTC) #2
Mads Ager (chromium)
LGTM
6 years, 3 months ago (2014-09-09 13:28:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/552143003/1
6 years, 3 months ago (2014-09-09 13:31:00 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/14747)
6 years, 3 months ago (2014-09-09 13:36:32 UTC) #8
haraken
LGTM
6 years, 3 months ago (2014-09-09 14:14:37 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/552143003/1
6 years, 3 months ago (2014-09-09 14:29:26 UTC) #11
commit-bot: I haz the power
6 years, 3 months ago (2014-09-09 15:27:10 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 181653

Powered by Google App Engine
This is Rietveld 408576698