Support app.window.create on athena

Support app.window.create on athena

*src/athena
Change ShellAppActivity to accept both AppWindow and ShellAppWindow.
Implement AppsClient to create NativeAppWindow and AppDelegate instances.

*src/extensions/shell
Add a new method DefaultShellBrowserMainDelegate::CreateAppsClient() to inject athena's AppsClient.

*src/extensions/browser
Add missing dtor to extensions::AppsClient to destroy an instance with a base class pointer in DefaultShellBrowserMainDelegate.

BUG=387288
TBR=benwells@chromium.org for the addition of the missing dtor of extensions::AppsClient.

Committed: https://crrev.com/68096136752418afb7fe4110e928921786439f18
Cr-Commit-Position: refs/heads/master@{#294363}

[hashimoto, 2014-09-10 11:00:03]

hashimoto@chromium.org changed reviewers:
+ jamescook@chromium.org, oshima@chromium.org

[hashimoto, 2014-09-10 11:00:04]

After this patch and another (https://codereview.chromium.org/546683002/) get
landed, it will be possible to use chrome.app.window.create API on athena.

oshima: Please review src/athena.
jamescook: Please review extensions/shell

[oshima, 2014-09-10 16:11:16]

athena lgtm, with nits and fyi.

https://codereview.chromium.org/552133003/diff/1/athena/main/athena_main.cc
File athena/main/athena_main.cc (right):

https://codereview.chromium.org/552133003/diff/1/athena/main/athena_main.cc#n...
athena/main/athena_main.cc:92: public:
// extensions::AppsClient:

https://codereview.chromium.org/552133003/diff/1/athena/main/athena_main.cc#n...
athena/main/athena_main.cc:111: return new
extensions::ShellNativeAppWindow(window, params);
FYI: CreateAppActivity currently creates its own widget. I'm changing this to
use the native app window instead.

https://codereview.chromium.org/552133003/diff/1/athena/main/athena_main.cc#n...
athena/main/athena_main.cc:126: };
disallow_copy_and_assign

[James Cook, 2014-09-10 18:48:47]

LGTM

Let me know if you would like me to help with any of this (AppsClient ->
AppWindowClient, removing ShellAppWindow, etc.)

[hashimoto, 2014-09-11 06:26:19]

Patchset #3 (id:40001) has been deleted

[hashimoto, 2014-09-11 06:26:35]

https://codereview.chromium.org/552133003/diff/1/athena/main/athena_main.cc
File athena/main/athena_main.cc (right):

https://codereview.chromium.org/552133003/diff/1/athena/main/athena_main.cc#n...
athena/main/athena_main.cc:92: public:
On 2014/09/10 16:11:16, oshima wrote:
> // extensions::AppsClient:

Done.

https://codereview.chromium.org/552133003/diff/1/athena/main/athena_main.cc#n...
athena/main/athena_main.cc:111: return new
extensions::ShellNativeAppWindow(window, params);
On 2014/09/10 16:11:16, oshima wrote:
> FYI: CreateAppActivity currently creates its own widget. I'm changing this to
> use the native app window instead.

Can't athena be satisfied with aura::Window* instead of views::Widget*?
NativeAppWindow exposes aura::Window*, but no views::Widget.

Though, it's not impossible to get views::Widget* from AppWindow if we replace
ShellNativeAppWindow with NativeAppWindowViews and cast the NativeAppWindow*
pointer returned by AppWindow::GetBaseWindow to NativeAppWindowViews*.

https://codereview.chromium.org/552133003/diff/1/athena/main/athena_main.cc#n...
athena/main/athena_main.cc:126: };
On 2014/09/10 16:11:16, oshima wrote:
> disallow_copy_and_assign

Done.

[hashimoto, 2014-09-11 06:27:00]

hashimoto@chromium.org changed reviewers:
+ benwells@chromium.org

[hashimoto, 2014-09-11 06:27:14]

TBRing benwells@chromium.org for the addition of the missing dtor of
extensions::AppsClient.

[hashimoto, 2014-09-11 06:27:18]

The CQ bit was checked by hashimoto@chromium.org

[hashimoto, 2014-09-11 06:29:25]

Patchset #3 (id:60001) has been deleted

[hashimoto, 2014-09-11 06:29:40]

The CQ bit was checked by hashimoto@chromium.org

[commit-bot: I haz the power, 2014-09-11 06:29:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/552133003/80001

[oshima, 2014-09-11 08:05:31]

On 2014/09/11 06:26:35, hashimoto wrote:
> https://codereview.chromium.org/552133003/diff/1/athena/main/athena_main.cc
> File athena/main/athena_main.cc (right):
> 
>
https://codereview.chromium.org/552133003/diff/1/athena/main/athena_main.cc#n...
> athena/main/athena_main.cc:92: public:
> On 2014/09/10 16:11:16, oshima wrote:
> > // extensions::AppsClient:
> 
> Done.
> 
>
https://codereview.chromium.org/552133003/diff/1/athena/main/athena_main.cc#n...
> athena/main/athena_main.cc:111: return new
> extensions::ShellNativeAppWindow(window, params);
> On 2014/09/10 16:11:16, oshima wrote:
> > FYI: CreateAppActivity currently creates its own widget. I'm changing this
to
> > use the native app window instead.
> 
> Can't athena be satisfied with aura::Window* instead of views::Widget*?
> NativeAppWindow exposes aura::Window*, but no views::Widget.
> 
> Though, it's not impossible to get views::Widget* from AppWindow if we replace
> ShellNativeAppWindow with NativeAppWindowViews and cast the NativeAppWindow*
> pointer returned by AppWindow::GetBaseWindow to NativeAppWindowViews*.

Athena will have its own NativeAppWindowViews, so NAWV should not have to expose
it (hopefully).

> 
>
https://codereview.chromium.org/552133003/diff/1/athena/main/athena_main.cc#n...
> athena/main/athena_main.cc:126: };
> On 2014/09/10 16:11:16, oshima wrote:
> > disallow_copy_and_assign
> 
> Done.

[commit-bot: I haz the power, 2014-09-11 08:31:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-11 08:31:34]

Exceeded time limit waiting for builds to trigger.

[hashimoto, 2014-09-11 08:31:54]

The CQ bit was checked by hashimoto@chromium.org

[commit-bot: I haz the power, 2014-09-11 08:32:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/552133003/80001

[commit-bot: I haz the power, 2014-09-11 09:16:30]

Committed patchset #3 (id:80001) as 71fb6afd84b75630121c021114f5c730cf03e270

[commit-bot: I haz the power, 2014-09-11 09:23:14]

Patchset 3 (id:??) landed as
https://crrev.com/68096136752418afb7fe4110e928921786439f18
Cr-Commit-Position: refs/heads/master@{#294363}