Issue 552123003: Create timing functions directly instead of using parser in KeyframeEffectModelTest

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 552123003: Create timing functions directly instead of using parser in KeyframeEffectModelTest (Closed)

Created:
6 years, 3 months ago by Timothy Loh

Modified:
6 years, 3 months ago

Reviewers:
dstockwell, rjwright, alancutter (OOO until 2018)

CC:
dstockwell, darktears, blink-reviews, blink-reviews-animation_chromium.org, Eric Willigers, Mike Lawther (Google), rjwright, shans, Steve Block, Timothy Loh

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

More Reviews

Description

Create timing functions directly instead of using parser in KeyframeEffectModelTest As the tests in KeyframeEffectModelTest are unit tests, it doesn't make sense for them to use the parser to construct timing functions when they can be constructed directly. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181609