Add ONC 'Source' configuration property

chrome/browser/resources/options/chromeos/onc_data.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview ONC Data support class. Wraps a dictionary object containing
  * ONC managed or unmanaged dictionaries. Supports nested dictionaries,
  * e.g. data.getManagedProperty('VPN.Type').
  */
 cr.define('cr.onc', function() {
@@ skipping 115 matching lines @@
         return undefined;
       if (property['UserEditable'])
         return property['UserPolicy'];
       if (property['DeviceEditable'])
         return property['DevicePolicy'];
       // No value recommended by policy.
       return undefined;
     },
 
     /**
+     * Returns the Source of this configuration. If undefined return 'None'.
+     * @return {string} The configuration source: 'None', 'User' or 'Device'.
+     */
+    getSource: function() {
+      var source = this.getActiveValue('Source');

[pneubeck (no reviews), 2014/09/09 19:35:32]

we should ensure that the ConfigurationHandler always sends the Source.

[stevenjb, 2014/09/10 00:00:55]

That seems unnecessarily verbose to me, and would involve changing a lot of test
expectations.

[stevenjb, 2014/09/10 00:26:01]

Also, in practice, any configuration that actually comes from Shill will have
the Profile property set so 'Source' will also be set, i.e. the code below is
only a convenience to support the fake implementations.

[pneubeck (no reviews), 2014/09/10 10:49:38]

Ah, I didn't mean to remove this fallback handling here.

Instead, I just meant that Source should always be send.
For != None, this is obviously a requirement.
For 'None' this is arguable, you're right. We could also not send the default
value 'None' as we do for some other properties.

On 2014/09/10 00:26:01, stevenjb wrote:

+      if (source == undefined)
+        return 'None';
+      return source;
+    },
+
+

[pneubeck (no reviews), 2014/09/09 19:35:31]

nit: remove empty line

[stevenjb, 2014/09/10 00:00:55]

Done.

+    /**
+     * Returns the WiFi security type where undefined == 'None'.

[pneubeck (no reviews), 2014/09/09 19:35:32]

nit:
" where undefined == 'None'." -> " with default value 'None'

[stevenjb, 2014/09/10 00:00:55]

Done.

+     * @return {string} The secuirity type.

[pneubeck (no reviews), 2014/09/09 19:35:32]

typo: secuirity

[stevenjb, 2014/09/10 00:00:55]

Done.

+     */
+    getWiFiSecurity: function() {
+      var security = this.getActiveValue('WiFi.Security');
+      if (security == undefined)
+        return 'None';
+      return security;
+    },
+
+   /**
      * Updates the properties of |data_| from the properties in |update|.
      * Note: this only looks at top level entries, so if a dictionary is
      * updated the entire dictionary is written over. TODO(stevenjb):
      * eliminate this function when |data_| contains only ONC entries and
      * any updates consist of complete ONC dictionaries.
      * @param {Object} update Dictionary containing the updated properties.
      */
     updateData: function(update) {
       for (var prop in update) {
         if (prop in this.data_)
@@ skipping 14 matching lines @@
           return property[effective];
       }
       return undefined;
     }
   };
 
   return {
     OncData: OncData
   };
 });