Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 552103003: Remove trailing '\' to avoid build failure on gcc 4.x toolchain. (Closed)

Created:
6 years, 3 months ago by vivekg_samsung
Modified:
6 years, 3 months ago
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove trailing '\' to avoid build failure on gcc 4.x toolchain. The trailing '\' on a comment line produces following error on gcc 4.8 chrome/browser/extensions/chrome_url_request_util.h:29:1: error: multi-line comment [-Werror=comment] TBR=fsamuel@chromium.org, lfg@chromium.org, rockot@chromium.org NOTRY=true Committed: https://crrev.com/33f197bf06e457f0a2a3616f15e0f44683cc2a2c Cr-Commit-Position: refs/heads/master@{#295278}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/extensions/chrome_url_request_util.h View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/url_request_util.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
vivekg
PTAL, thanks!
6 years, 3 months ago (2014-09-17 05:19:36 UTC) #2
lfg
lgtm +rockot as I'm not an owner of those files.
6 years, 3 months ago (2014-09-17 15:19:18 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/552103003/1
6 years, 3 months ago (2014-09-17 15:25:50 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as 853bb84c352cec492b1473c32bc1cef241d533d4
6 years, 3 months ago (2014-09-17 15:26:28 UTC) #9
commit-bot: I haz the power
6 years, 3 months ago (2014-09-17 15:27:09 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/33f197bf06e457f0a2a3616f15e0f44683cc2a2c
Cr-Commit-Position: refs/heads/master@{#295278}

Powered by Google App Engine
This is Rietveld 408576698