Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(752)

Side by Side Diff: chrome/browser/sync/test/integration/two_client_bookmarks_sync_test.cc

Issue 552093003: Disable TwoClientBookmarksSyncTest.SC_MovingBMsFromBMBarToBMFolder and TwoClientBookmarksSyncTest.S… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/rand_util.h" 5 #include "base/rand_util.h"
6 #include "chrome/browser/profiles/profile.h" 6 #include "chrome/browser/profiles/profile.h"
7 #include "chrome/browser/sync/test/integration/bookmarks_helper.h" 7 #include "chrome/browser/sync/test/integration/bookmarks_helper.h"
8 #include "chrome/browser/sync/test/integration/passwords_helper.h" 8 #include "chrome/browser/sync/test/integration/passwords_helper.h"
9 #include "chrome/browser/sync/test/integration/profile_sync_service_harness.h" 9 #include "chrome/browser/sync/test/integration/profile_sync_service_harness.h"
10 #include "chrome/browser/sync/test/integration/sync_integration_test_util.h" 10 #include "chrome/browser/sync/test/integration/sync_integration_test_util.h"
(...skipping 812 matching lines...) Expand 10 before | Expand all | Expand 10 after
823 } 823 }
824 ASSERT_TRUE(GetClient(0)->AwaitMutualSyncCycleCompletion(GetClient(1))); 824 ASSERT_TRUE(GetClient(0)->AwaitMutualSyncCycleCompletion(GetClient(1)));
825 ASSERT_TRUE(AllModelsMatchVerifier()); 825 ASSERT_TRUE(AllModelsMatchVerifier());
826 826
827 ReverseChildOrder(0, GetBookmarkBarNode(0)); 827 ReverseChildOrder(0, GetBookmarkBarNode(0));
828 ASSERT_TRUE(GetClient(0)->AwaitMutualSyncCycleCompletion(GetClient(1))); 828 ASSERT_TRUE(GetClient(0)->AwaitMutualSyncCycleCompletion(GetClient(1)));
829 ASSERT_TRUE(AllModelsMatchVerifier()); 829 ASSERT_TRUE(AllModelsMatchVerifier());
830 } 830 }
831 831
832 // Test Scribe ID - 371954. 832 // Test Scribe ID - 371954.
833 // flaky on Windows: http://crbug.com/412169
834 #if defined(OS_WIN)
835 #define MAYBE_SC_MovingBMsFromBMBarToBMFolder DISABLED_SC_MovingBMsFromBMBarToBM Folder
836 #else
837 #define MAYBE_SC_MovingBMsFromBMBarToBMFolder SC_MovingBMsFromBMBarToBMFolder
838 #endif
833 IN_PROC_BROWSER_TEST_F(TwoClientBookmarksSyncTest, 839 IN_PROC_BROWSER_TEST_F(TwoClientBookmarksSyncTest,
834 SC_MovingBMsFromBMBarToBMFolder) { 840 MAYBE_SC_MovingBMsFromBMBarToBMFolder) {
835 ASSERT_TRUE(SetupSync()) << "SetupSync() failed."; 841 ASSERT_TRUE(SetupSync()) << "SetupSync() failed.";
836 ASSERT_TRUE(AllModelsMatchVerifier()); 842 ASSERT_TRUE(AllModelsMatchVerifier());
837 843
838 ASSERT_TRUE(AddURL(0, kGenericURLTitle, GURL(kGenericURL)) != NULL); 844 ASSERT_TRUE(AddURL(0, kGenericURLTitle, GURL(kGenericURL)) != NULL);
839 const BookmarkNode* folder = AddFolder(0, 1, kGenericFolderName); 845 const BookmarkNode* folder = AddFolder(0, 1, kGenericFolderName);
840 ASSERT_TRUE(folder != NULL); 846 ASSERT_TRUE(folder != NULL);
841 for (int i = 2; i < 10; ++i) { 847 for (int i = 2; i < 10; ++i) {
842 std::string title = IndexedURLTitle(i); 848 std::string title = IndexedURLTitle(i);
843 GURL url = GURL(IndexedURL(i)); 849 GURL url = GURL(IndexedURL(i));
844 ASSERT_TRUE(AddURL(0, i, title, url) != NULL); 850 ASSERT_TRUE(AddURL(0, i, title, url) != NULL);
845 } 851 }
846 ASSERT_TRUE(GetClient(0)->AwaitMutualSyncCycleCompletion(GetClient(1))); 852 ASSERT_TRUE(GetClient(0)->AwaitMutualSyncCycleCompletion(GetClient(1)));
847 ASSERT_TRUE(AllModelsMatchVerifier()); 853 ASSERT_TRUE(AllModelsMatchVerifier());
848 854
849 int num_bookmarks_to_move = 855 int num_bookmarks_to_move =
850 GetBookmarkBarNode(0)->child_count() - 2; 856 GetBookmarkBarNode(0)->child_count() - 2;
851 for (int i = 0; i < num_bookmarks_to_move; ++i) { 857 for (int i = 0; i < num_bookmarks_to_move; ++i) {
852 Move( 858 Move(
853 0, GetBookmarkBarNode(0)->GetChild(2), folder, i); 859 0, GetBookmarkBarNode(0)->GetChild(2), folder, i);
854 ASSERT_TRUE(GetClient(0)->AwaitMutualSyncCycleCompletion(GetClient(1))); 860 ASSERT_TRUE(GetClient(0)->AwaitMutualSyncCycleCompletion(GetClient(1)));
855 ASSERT_TRUE(AllModelsMatchVerifier()); 861 ASSERT_TRUE(AllModelsMatchVerifier());
856 } 862 }
857 } 863 }
858 864
859 // Test Scribe ID - 371957. 865 // Test Scribe ID - 371957.
866 // flaky on Windows: http://crbug.com/412169
867 #if defined(OS_WIN)
868 #define MAYBE_SC_MovingBMsFromBMFoldToBMBar DISABLED_SC_MovingBMsFromBMFoldToBMB ar
869 #else
870 #define MAYBE_SC_MovingBMsFromBMFoldToBMBar SC_MovingBMsFromBMFoldToBMBar
871 #endif
860 IN_PROC_BROWSER_TEST_F(TwoClientBookmarksSyncTest, 872 IN_PROC_BROWSER_TEST_F(TwoClientBookmarksSyncTest,
861 SC_MovingBMsFromBMFoldToBMBar) { 873 MAYBE_SC_MovingBMsFromBMFoldToBMBar) {
862 ASSERT_TRUE(SetupSync()) << "SetupSync() failed."; 874 ASSERT_TRUE(SetupSync()) << "SetupSync() failed.";
863 ASSERT_TRUE(AllModelsMatchVerifier()); 875 ASSERT_TRUE(AllModelsMatchVerifier());
864 876
865 ASSERT_TRUE(AddURL(0, kGenericURLTitle, GURL(kGenericURL)) != NULL); 877 ASSERT_TRUE(AddURL(0, kGenericURLTitle, GURL(kGenericURL)) != NULL);
866 const BookmarkNode* folder = AddFolder(0, 1, kGenericFolderName); 878 const BookmarkNode* folder = AddFolder(0, 1, kGenericFolderName);
867 ASSERT_TRUE(folder != NULL); 879 ASSERT_TRUE(folder != NULL);
868 for (int i = 0; i < 10; ++i) { 880 for (int i = 0; i < 10; ++i) {
869 std::string title = IndexedURLTitle(i); 881 std::string title = IndexedURLTitle(i);
870 GURL url = GURL(IndexedURL(i)); 882 GURL url = GURL(IndexedURL(i));
871 ASSERT_TRUE(AddURL(0, folder, i, title, url) != NULL); 883 ASSERT_TRUE(AddURL(0, folder, i, title, url) != NULL);
(...skipping 1151 matching lines...) Expand 10 before | Expand all | Expand 10 after
2023 2035
2024 // Remove all 2036 // Remove all
2025 RemoveAll(0); 2037 RemoveAll(0);
2026 2038
2027 ASSERT_TRUE(GetClient(0)->AwaitMutualSyncCycleCompletion(GetClient(1))); 2039 ASSERT_TRUE(GetClient(0)->AwaitMutualSyncCycleCompletion(GetClient(1)));
2028 // Verify other node has no children now. 2040 // Verify other node has no children now.
2029 EXPECT_EQ(0, GetOtherNode(0)->child_count()); 2041 EXPECT_EQ(0, GetOtherNode(0)->child_count());
2030 EXPECT_EQ(0, GetBookmarkBarNode(0)->child_count()); 2042 EXPECT_EQ(0, GetBookmarkBarNode(0)->child_count());
2031 ASSERT_TRUE(AllModelsMatch()); 2043 ASSERT_TRUE(AllModelsMatch());
2032 } 2044 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698