Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 552053005: Folds ui/base/ime/BUILD.gn into ui/base (to fix circular dependencies) (Closed)

Created:
6 years, 3 months ago by sky
Modified:
6 years, 3 months ago
Reviewers:
brettw
CC:
chromium-reviews, nona+watch_chromium.org, James Su, yukishiino+watch_chromium.org, penghuang+watch_chromium.org, yusukes+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Folds ui/base/ime/BUILD.gn into ui/base Which is what we do on the gyp side too. Going this route rather than a different BUILD.gn as there aren't a lot of files and we don't have separate components on the gyp side. BUG=408648 TEST=none R=brettw@chromium.org Committed: https://crrev.com/b4610c2794a2578e7ec23733e630792e1a44d852 Cr-Commit-Position: refs/heads/master@{#294415}

Patch Set 1 #

Patch Set 2 : fix #

Patch Set 3 : build_ime #

Patch Set 4 : \!is_ios #

Unified diffs Side-by-side diffs Delta from patch set Stats (+121 lines, -129 lines) Patch
M ui/base/BUILD.gn View 1 2 3 5 chunks +121 lines, -15 lines 0 comments Download
D ui/base/ime/BUILD.gn View 1 chunk +0 lines, -114 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
sky
6 years, 3 months ago (2014-09-10 19:13:07 UTC) #1
brettw
Can you fix the CL description to say why we don't want this split (the ...
6 years, 3 months ago (2014-09-11 05:29:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/552053005/40001
6 years, 3 months ago (2014-09-11 14:56:58 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_rel/builds/14554)
6 years, 3 months ago (2014-09-11 15:15:04 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/552053005/60001
6 years, 3 months ago (2014-09-11 16:41:22 UTC) #8
commit-bot: I haz the power
Committed patchset #4 (id:60001) as 496c3ef56d632538f7d2d3d51ebf0cd12e33c578
6 years, 3 months ago (2014-09-11 17:44:32 UTC) #9
commit-bot: I haz the power
6 years, 3 months ago (2014-09-11 18:42:53 UTC) #10
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/b4610c2794a2578e7ec23733e630792e1a44d852
Cr-Commit-Position: refs/heads/master@{#294415}

Powered by Google App Engine
This is Rietveld 408576698