Source/core/html/canvas/CanvasRenderingContext2D.cpp - Issue 552053003: CanvasRenderingContext2D should update the render tree to avoid stale computed style.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/canvas/CanvasRenderingContext2D.cpp

Issue 552053003: CanvasRenderingContext2D should update the render tree to avoid stale computed style. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Test added! Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/fast/canvas/canvas-set-font-with-updated-style.html ('K') | « LayoutTests/fast/canvas/canvas-set-font-with-updated-style-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/html/canvas/CanvasRenderingContext2D.cpp

diff --git a/Source/core/html/canvas/CanvasRenderingContext2D.cpp b/Source/core/html/canvas/CanvasRenderingContext2D.cpp

index e8bba71a7f9b8e321d84acb3a0e3db68c5f25874..3f95c02f4729c2ccbd15614d9a9f0469b4287744 100644

--- a/Source/core/html/canvas/CanvasRenderingContext2D.cpp

+++ b/Source/core/html/canvas/CanvasRenderingContext2D.cpp

@@ -1950,6 +1950,7 @@ void CanvasRenderingContext2D::setFont(const String& newFont)

// Map the <canvas> font into the text style. If the font uses keywords like larger/smaller, these will work

// relative to the canvas.

RefPtr<RenderStyle> newStyle = RenderStyle::create();

+ canvas()->document().updateRenderTreeIfNeeded();

if (RenderStyle* computedStyle = canvas()->computedStyle()) {

FontDescription elementFontDescription(computedStyle->fontDescription());

// Reset the computed size to avoid inheriting the zoom factor from the <canvas> element.