Add doc to OS::StrNCpy

Add doc to OS::StrNCpy

[Mads Ager (chromium), 2010-01-19 16:07:06]

http://codereview.chromium.org/552042/diff/1001/4
File src/platform.h (right):

http://codereview.chromium.org/552042/diff/1001/4#newcode244
src/platform.h:244: // Calls strncpy in POSIX and strncpy_s in Windows. It means
that
I think it would make more sense to change the implementation of StrNCpy to work
the same on all platforms.  Why don't we change StrNCpy to always null terminate
and document this consistent behavior instead?

[Søren Thygesen Gjesse, 2010-01-19 16:13:06]

http://codereview.chromium.org/552042/diff/1001/4
File src/platform.h (right):

http://codereview.chromium.org/552042/diff/1001/4#newcode244
src/platform.h:244: // Calls strncpy in POSIX and strncpy_s in Windows. It means
that
Then we should probably stick to the strncpy_s semantics where the dest[0] is
set to '\0' if dest does not have room for the n characters.

[Peter Rybin, 2010-01-19 16:25:11]

I totally agree we ought to fix this. I think clearly reads between the lines of
comment :)

The only question is should we put the current doc (possibly with TODO) now or
not.
I got used to putting docs/TODO first, and then fixing it.
However, it's a matter of taste.

On 2010/01/19 16:13:06, Søren Gjesse wrote:
> http://codereview.chromium.org/552042/diff/1001/4
> File src/platform.h (right):
> 
> http://codereview.chromium.org/552042/diff/1001/4#newcode244
> src/platform.h:244: // Calls strncpy in POSIX and strncpy_s in Windows. It
means
> that
> Then we should probably stick to the strncpy_s semantics where the dest[0] is
> set to '\0' if dest does not have room for the n characters.