Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(573)

Issue 55203003: Add TargetIsPing and have PingLoader use it. (Closed)

Created:
7 years, 1 month ago by davidben
Modified:
7 years, 1 month ago
Reviewers:
abarth-chromium
CC:
blink-reviews, jamesr, dglazkov+blink, Nate Chapin, gavinp+loader_chromium.org, abarth-chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Add TargetIsPing and have PingLoader use it. We'll use it to detach requests from renderers. This is used both for PingLoader::loadImage and PingLoader::sendPing. Temporarily define a WEBKIT_HAS_TARGET_IS_PING preprocessor symbol until Chromium downstream is updated. (Even though the former comes from loading an image, it's part of the special-case behavior where images loaded in unload handlers don't get cancelled, and doesn't load like a normal image, so we shouldn't be treating it as one.) BUG=302816 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=162565

Patch Set 1 #

Patch Set 2 : New plan (see second comment) #

Patch Set 3 : rebase #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M Source/core/loader/PingLoader.cpp View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M Source/platform/network/ResourceRequest.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M public/platform/WebURLRequest.h View 1 2 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
davidben
7 years, 1 month ago (2013-10-31 22:28:39 UTC) #1
davidben
Actually, better plan, based on how ResourceType::XHR was added. This shouldn't land until a preparatory ...
7 years, 1 month ago (2013-10-31 22:50:18 UTC) #2
abarth-chromium
LGTM
7 years, 1 month ago (2013-11-01 17:05:41 UTC) #3
davidben
On 2013/11/01 17:05:41, abarth wrote: > LGTM https://codereview.chromium.org/55513002/ and the (re-)land of its prerequisite finally ...
7 years, 1 month ago (2013-11-22 21:01:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/davidben@chromium.org/55203003/110001
7 years, 1 month ago (2013-11-22 21:02:09 UTC) #5
commit-bot: I haz the power
7 years, 1 month ago (2013-11-22 22:26:32 UTC) #6
Message was sent while issue was closed.
Change committed as 162565

Powered by Google App Engine
This is Rietveld 408576698