Issue 552023002: Move ownership of HostPairingController from PairingScreen to WizardController.

Issue 552023002: Move ownership of HostPairingController from PairingScreen to WizardController. (Closed)

Created:
6 years, 3 months ago by Zachary Kuznia

Modified:
6 years, 3 months ago

Reviewers:
achuithb

CC:
dzhioev (left Google)

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Move ownership of HostPairingController from PairingScreen to WizardController. BUG=381007 Committed: https://crrev.com/70b3cd8a68e65219b041b6f13e28f5fe46915b0e Cr-Commit-Position: refs/heads/master@{#293838}

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+21 lines, -9 lines)			Patch
M	chrome/browser/chromeos/login/screens/host_pairing_screen.h	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/chromeos/login/screens/host_pairing_screen.cc	View	1 chunk	+6 lines, -4 lines	0 comments	Download
M	chrome/browser/chromeos/login/wizard_controller.h	View	2 chunks	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/login/wizard_controller.cc	View	2 chunks	+7 lines, -1 line	0 comments	Download

Total messages: 7 (2 generated)

achuithb

Let's use BUG=381007 for this. I'm still a bit sketched out by the lifetime conventions ...

6 years, 3 months ago (2014-09-08 22:01:20 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zork@chromium.org/552023002/1

6 years, 3 months ago (2014-09-08 22:10:49 UTC) #5

commit-bot: I haz the power

Committed patchset #1 (id:1) as c3885c5b2970f9dd0506c7def25f8f6b52af0084

6 years, 3 months ago (2014-09-09 02:29:50 UTC) #6

commit-bot: I haz the power

6 years, 3 months ago (2014-09-10 03:49:51 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/70b3cd8a68e65219b041b6f13e28f5fe46915b0e
Cr-Commit-Position: refs/heads/master@{#293838}