Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Unified Diff: tools/bisect-perf-regression_test.py

Issue 552013008: Replace "git svn" with "git footers" commands to get commit position or svn revision. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/bisect-perf-regression.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/bisect-perf-regression_test.py
diff --git a/tools/bisect-perf-regression_test.py b/tools/bisect-perf-regression_test.py
index 16a3f13f0a513c278f933f12c66782fe524c423e..b91179216293505e5d893d6fa4c0c8a238324a94 100644
--- a/tools/bisect-perf-regression_test.py
+++ b/tools/bisect-perf-regression_test.py
@@ -255,16 +255,32 @@ class BisectPerfRegressionTest(unittest.TestCase):
bisect_instance.opts.metric)
bisect_instance.FormatAndPrintResults(results)
- def testSVNFindRev(self):
- """Determine numerical SVN revision or Commit Position."""
+ def testGetCommitPosition(self):
bisect_instance = _GetBisectPerformanceMetricsInstance()
cp_git_rev = '7017a81991de983e12ab50dfc071c70e06979531'
- self.assertEqual(291765,
- bisect_instance.source_control.SVNFindRev(cp_git_rev))
+ self.assertEqual(
+ 291765, bisect_instance.source_control.GetCommitPosition(cp_git_rev))
svn_git_rev = 'e6db23a037cad47299a94b155b95eebd1ee61a58'
- self.assertEqual(291467,
- bisect_instance.source_control.SVNFindRev(svn_git_rev))
+ self.assertEqual(
+ 291467, bisect_instance.source_control.GetCommitPosition(svn_git_rev))
+
+ def testGetCommitPositionForV8(self):
+ bisect_instance = _GetBisectPerformanceMetricsInstance()
+ v8_rev = '21d700eedcdd6570eff22ece724b63a5eefe78cb'
+ depot_path = os.path.join(bisect_instance.src_cwd, 'src', 'v8')
+ self.assertEqual(
+ 23634,
+ bisect_instance.source_control.GetCommitPosition(v8_rev, depot_path))
+
+ def testGetCommitPositionForWebKit(self):
+ bisect_instance = _GetBisectPerformanceMetricsInstance()
+ wk_rev = 'a94d028e0f2c77f159b3dac95eb90c3b4cf48c61'
+ depot_path = os.path.join(bisect_instance.src_cwd, 'src', 'third_party',
+ 'WebKit')
+ self.assertEqual(
+ 181660,
+ bisect_instance.source_control.GetCommitPosition(wk_rev, depot_path))
def testUpdateDepsContent(self):
bisect_instance = _GetBisectPerformanceMetricsInstance()
« no previous file with comments | « tools/bisect-perf-regression.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698