Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(383)

Issue 552013005: Use GuestViewBase for creating constrained windows instead of WebViewGuest. (Closed)

Created:
6 years, 3 months ago by lazyboy
Modified:
6 years, 3 months ago
Reviewers:
Lei Zhang, Fady Samuel
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Use GuestViewBase for creating constrained windows instead of WebViewGuest. This will allow features that use constrained windows (e.g. printing) work on all guest views: app-view/web-view/mime-handler-view, etc. BUG=411765 Test=This is internal only for now, nothing visible, once the full support for printing and saving mime-handler-view lands it will be used. Committed: https://crrev.com/bd330a25b1d8710d6267c31df70c880c7a39bc24 Cr-Commit-Position: refs/heads/master@{#293898}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -10 lines) Patch
M chrome/browser/ui/cocoa/constrained_window/constrained_window_mac.mm View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/constrained_window_views.cc View 2 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
lazyboy
Fady, can you send me your initial thoughts about this? Since constrained windows is sth ...
6 years, 3 months ago (2014-09-09 02:04:13 UTC) #2
Fady Samuel
No objections, lgtm
6 years, 3 months ago (2014-09-09 02:08:25 UTC) #3
lazyboy
+thestig for OWNERS review.
6 years, 3 months ago (2014-09-09 06:38:47 UTC) #5
Lei Zhang
lgtm
6 years, 3 months ago (2014-09-09 06:43:33 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lazyboy@chromium.org/552013005/1
6 years, 3 months ago (2014-09-09 06:45:01 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as 79d1715c5a6d3f9f46fe406c8fc710d94ddab3bd
6 years, 3 months ago (2014-09-09 09:03:05 UTC) #9
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:52:04 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bd330a25b1d8710d6267c31df70c880c7a39bc24
Cr-Commit-Position: refs/heads/master@{#293898}

Powered by Google App Engine
This is Rietveld 408576698