Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 552013004: Include <string> and <istream> outside __pnacl__. (Closed)

Created:
6 years, 3 months ago by pbos
Modified:
6 years, 3 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Include <string> and <istream> outside __pnacl__. Fixes webrtc/ Debug build with libc++ which failed to link std::getline as this is defined in <istream>. <iostream> causes static initializers and shouldn't be necessary. Also adds to README.chromium that the overrides are used too get rid of static initializers and to build on libc++. R=thakis@chromium.org TBR=ronghuawu@chromium.org BUG=webrtc:3739 Committed: https://crrev.com/6455c698e51af65f57a8fe83547296218a5a7251 Cr-Commit-Position: refs/heads/master@{#293954}

Patch Set 1 #

Patch Set 2 : added comment #

Patch Set 3 : removed comment and added it in readme #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -10 lines) Patch
M third_party/jsoncpp/README.chromium View 1 2 1 chunk +5 lines, -1 line 0 comments Download
M third_party/jsoncpp/overrides/src/lib_json/json_reader.cpp View 1 2 1 chunk +1 line, -9 lines 0 comments Download

Messages

Total messages: 11 (2 generated)
Nico
If this works, we should try reverting the jsoncpp changes of https://codereview.chromium.org/98713004 instead.
6 years, 3 months ago (2014-09-09 00:41:28 UTC) #1
pbos
On 2014/09/09 00:41:28, Nico (hiding) wrote: > If this works, we should try reverting the ...
6 years, 3 months ago (2014-09-09 08:19:31 UTC) #2
pbos
On 2014/09/09 08:19:31, pbos wrote: > On 2014/09/09 00:41:28, Nico (hiding) wrote: > > If ...
6 years, 3 months ago (2014-09-09 08:21:12 UTC) #3
pbos
On 2014/09/09 08:21:12, pbos wrote: > On 2014/09/09 08:19:31, pbos wrote: > > On 2014/09/09 ...
6 years, 3 months ago (2014-09-09 08:37:39 UTC) #4
Nico
lgtm with comment adjusted as discussed; mention in the cl description that the override file ...
6 years, 3 months ago (2014-09-09 15:16:46 UTC) #5
pbos
On 2014/09/09 15:16:46, Nico (hiding) wrote: > lgtm with comment adjusted as discussed; mention in ...
6 years, 3 months ago (2014-09-09 15:21:11 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pbos@chromium.org/552013004/60001
6 years, 3 months ago (2014-09-09 15:35:55 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:60001) as 2c993b1de9d0a7f27ca969500cdeb55a08508e2e
6 years, 3 months ago (2014-09-09 16:56:02 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:53:52 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/6455c698e51af65f57a8fe83547296218a5a7251
Cr-Commit-Position: refs/heads/master@{#293954}

Powered by Google App Engine
This is Rietveld 408576698