Include <string> and <istream> outside __pnacl__.

Include <string> and <istream> outside __pnacl__.

Fixes webrtc/ Debug build with libc++ which failed to link std::getline
as this is defined in <istream>. <iostream> causes static initializers
and shouldn't be necessary.

Also adds to README.chromium that the overrides are used too get rid of
static initializers and to build on libc++.

R=thakis@chromium.org
TBR=ronghuawu@chromium.org
BUG=webrtc:3739
Committed: https://crrev.com/6455c698e51af65f57a8fe83547296218a5a7251
Cr-Commit-Position: refs/heads/master@{#293954}

[Nico, 2014-09-09 00:41:28]

If this works, we should try reverting the jsoncpp changes of
https://codereview.chromium.org/98713004 instead.

[pbos, 2014-09-09 08:19:31]

On 2014/09/09 00:41:28, Nico (hiding) wrote:
> If this works, we should try reverting the jsoncpp changes of
> https://codereview.chromium.org/98713004 instead.

Commenting here since this might be the CL to go with (removing all overrides
add static initializers for at least json_value.cpp).

I see three options:

Removing all overrides (afaict. this gives static initializers in
json_value.cpp, but I'm not 100%) and rolling DEPS. This is assumed to be a
no-go based on the static initializers.

Removing overrides for json_reader.cpp. Requires rolling DEPS and updating the
overridden json_value.cpp, or we get linker errors. I'm not super-comfy with
doing updates in this file, here're the linker errors:

../../third_party/jsoncpp/source/src/lib_json/json_reader.cpp:217: error:
undefined reference to 'Json::Value::setOffsetLimit(unsigned long)'
../../third_party/jsoncpp/source/src/lib_json/json_reader.cpp:231: error:
undefined reference to 'Json::Value::setOffsetStart(unsigned long)'

This CL, and I'm starting to prefer it. WDYT?

[pbos, 2014-09-09 08:21:12]

On 2014/09/09 08:19:31, pbos wrote:
> On 2014/09/09 00:41:28, Nico (hiding) wrote:
> > If this works, we should try reverting the jsoncpp changes of
> > https://codereview.chromium.org/98713004 instead.
> 
> Commenting here since this might be the CL to go with (removing all overrides
> add static initializers for at least json_value.cpp).
> 
> I see three options:
> 
> Removing all overrides (afaict. this gives static initializers in
> json_value.cpp, but I'm not 100%) and rolling DEPS. This is assumed to be a
> no-go based on the static initializers.
> 
> Removing overrides for json_reader.cpp. Requires rolling DEPS and updating the
> overridden json_value.cpp, or we get linker errors. I'm not super-comfy with
> doing updates in this file, here're the linker errors:
> 
> ../../third_party/jsoncpp/source/src/lib_json/json_reader.cpp:217: error:
> undefined reference to 'Json::Value::setOffsetLimit(unsigned long)'
> ../../third_party/jsoncpp/source/src/lib_json/json_reader.cpp:231: error:
> undefined reference to 'Json::Value::setOffsetStart(unsigned long)'
> 
> This CL, and I'm starting to prefer it. WDYT?

To clarify: Rolling deps is required to get a version of json_reader.cpp that
includes <istream> and fixes the original issue, but that uses
Json::Value::setOffsetLimit etc. that's not built with our overridden
json_value.cpp.

[pbos, 2014-09-09 08:37:39]

On 2014/09/09 08:21:12, pbos wrote:
> On 2014/09/09 08:19:31, pbos wrote:
> > On 2014/09/09 00:41:28, Nico (hiding) wrote:
> > > If this works, we should try reverting the jsoncpp changes of
> > > https://codereview.chromium.org/98713004 instead.
> > 
> > Commenting here since this might be the CL to go with (removing all
overrides
> > add static initializers for at least json_value.cpp).
> > 
> > I see three options:
> > 
> > Removing all overrides (afaict. this gives static initializers in
> > json_value.cpp, but I'm not 100%) and rolling DEPS. This is assumed to be a
> > no-go based on the static initializers.
> > 
> > Removing overrides for json_reader.cpp. Requires rolling DEPS and updating
the
> > overridden json_value.cpp, or we get linker errors. I'm not super-comfy with
> > doing updates in this file, here're the linker errors:
> > 
> > ../../third_party/jsoncpp/source/src/lib_json/json_reader.cpp:217: error:
> > undefined reference to 'Json::Value::setOffsetLimit(unsigned long)'
> > ../../third_party/jsoncpp/source/src/lib_json/json_reader.cpp:231: error:
> > undefined reference to 'Json::Value::setOffsetStart(unsigned long)'
> > 
> > This CL, and I'm starting to prefer it. WDYT?
> 
> To clarify: Rolling deps is required to get a version of json_reader.cpp that
> includes <istream> and fixes the original issue, but that uses
> Json::Value::setOffsetLimit etc. that's not built with our overridden
> json_value.cpp.

I also added a comment that should clarify why this file is still here. PTAL.
<end spam>

[Nico, 2014-09-09 15:16:46]

lgtm with comment adjusted as discussed; mention in the cl description that the
override file exists to prevent an initializer for the Value global thing

[pbos, 2014-09-09 15:19:02]

Patchset #3 (id:40001) has been deleted

[pbos, 2014-09-09 15:21:11]

On 2014/09/09 15:16:46, Nico (hiding) wrote:
> lgtm with comment adjusted as discussed; mention in the cl description that
the
> override file exists to prevent an initializer for the Value global thing

moved comment to README.chromium, updated CL desc, ptal.

[pbos, 2014-09-09 15:35:40]

The CQ bit was checked by pbos@chromium.org

[commit-bot: I haz the power, 2014-09-09 15:35:55]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/pbos@chromium.org/552013004/60001

[commit-bot: I haz the power, 2014-09-09 16:56:02]

Committed patchset #3 (id:60001) as 2c993b1de9d0a7f27ca969500cdeb55a08508e2e

[commit-bot: I haz the power, 2014-09-10 03:53:52]

Patchset 3 (id:??) landed as
https://crrev.com/6455c698e51af65f57a8fe83547296218a5a7251
Cr-Commit-Position: refs/heads/master@{#293954}