Source/web/tests/WebFrameTest.cpp - Issue 551973005: Streamline frame detach

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/tests/WebFrameTest.cpp

Issue 551973005: Streamline frame detach (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/web/tests/WebFrameTest.cpp

diff --git a/Source/web/tests/WebFrameTest.cpp b/Source/web/tests/WebFrameTest.cpp

index 2d836ae64efb30d8d764cc3a251f32354adf4472..181628cc2773cc566094fc7a57d7f25a5fe1dd99 100644

--- a/Source/web/tests/WebFrameTest.cpp

+++ b/Source/web/tests/WebFrameTest.cpp

@@ -3575,9 +3575,7 @@ TEST_F(WebFrameTest, FindDetachFrameWhileScopingStrings)

EXPECT_FALSE(client.findResultsAreReady());

mainFrame->resetMatchCount();

- for (WebFrame* frame = mainFrame; frame; frame = frame->traverseNext(false))

- frame->scopeStringMatches(kFindIdentifier, searchText, options, true);

+ mainFrame->scopeStringMatches(kFindIdentifier, searchText, options, true);

// The first scopeStringMatches will have reset the state. Detach before it actually scopes.

EXPECT_TRUE(mainFrame->document().getElementById("frame").remove());