Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1099)

Unified Diff: Source/web/tests/WebFrameTest.cpp

Issue 551973005: Streamline frame detach (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« Source/core/frame/Frame.cpp ('K') | « Source/web/RemoteFrameClient.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/web/tests/WebFrameTest.cpp
diff --git a/Source/web/tests/WebFrameTest.cpp b/Source/web/tests/WebFrameTest.cpp
index f95fbd23da09a707ec037253a7b93ffb01ad7ec4..798312abbc74d5b48daeb580a4b67a8a797ce3a0 100644
--- a/Source/web/tests/WebFrameTest.cpp
+++ b/Source/web/tests/WebFrameTest.cpp
@@ -3576,9 +3576,7 @@ TEST_F(WebFrameTest, FindDetachFrameWhileScopingStrings)
EXPECT_FALSE(client.findResultsAreReady());
mainFrame->resetMatchCount();
-
- for (WebFrame* frame = mainFrame; frame; frame = frame->traverseNext(false))
- frame->scopeStringMatches(kFindIdentifier, searchText, options, true);
+ mainFrame->scopeStringMatches(kFindIdentifier, searchText, options, true);
// The first scopeStringMatches will have reset the state. Detach before it actually scopes.
EXPECT_TRUE(mainFrame->document().getElementById("frame").remove());
« Source/core/frame/Frame.cpp ('K') | « Source/web/RemoteFrameClient.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698