Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Side by Side Diff: Source/core/dom/NodeRareData.cpp

Issue 551973005: Streamline frame detach (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 14 matching lines...) Expand all
25 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY 25 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
26 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 26 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
27 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 27 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
29 */ 29 */
30 30
31 #include "config.h" 31 #include "config.h"
32 #include "core/dom/NodeRareData.h" 32 #include "core/dom/NodeRareData.h"
33 #include "core/dom/Element.h" 33 #include "core/dom/Element.h"
34 #include "core/dom/ElementRareData.h" 34 #include "core/dom/ElementRareData.h"
35 #include "core/page/Page.h" 35 #include "core/frame/FrameHost.h"
36 #include "core/rendering/RenderObject.h" 36 #include "core/rendering/RenderObject.h"
37 #include "platform/heap/Handle.h" 37 #include "platform/heap/Handle.h"
38 38
39 namespace blink { 39 namespace blink {
40 40
41 struct SameSizeAsNodeRareData { 41 struct SameSizeAsNodeRareData {
42 void* m_pointer[2]; 42 void* m_pointer[2];
43 OwnPtrWillBeMember<NodeMutationObserverData> m_mutationObserverData; 43 OwnPtrWillBeMember<NodeMutationObserverData> m_mutationObserverData;
44 unsigned m_bitfields; 44 unsigned m_bitfields;
45 }; 45 };
(...skipping 24 matching lines...) Expand all
70 void NodeRareData::finalizeGarbageCollectedObject() 70 void NodeRareData::finalizeGarbageCollectedObject()
71 { 71 {
72 RELEASE_ASSERT(!renderer()); 72 RELEASE_ASSERT(!renderer());
73 if (m_isElementRareData) 73 if (m_isElementRareData)
74 static_cast<ElementRareData*>(this)->~ElementRareData(); 74 static_cast<ElementRareData*>(this)->~ElementRareData();
75 else 75 else
76 this->~NodeRareData(); 76 this->~NodeRareData();
77 } 77 }
78 78
79 // Ensure the 10 bits reserved for the m_connectedFrameCount cannot overflow 79 // Ensure the 10 bits reserved for the m_connectedFrameCount cannot overflow
80 COMPILE_ASSERT(Page::maxNumberOfFrames < (1 << NodeRareData::ConnectedFrameCount Bits), Frame_limit_should_fit_in_rare_data_count); 80 COMPILE_ASSERT(FrameHost::maxNumberOfFrames < (1 << NodeRareData::ConnectedFrame CountBits), Frame_limit_should_fit_in_rare_data_count);
dcheng 2014/09/25 23:35:43 static_assert? =)
Nate Chapin 2014/09/25 23:57:50 Done.
81 81
82 } // namespace blink 82 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698