Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(525)

Issue 551973004: Clear away any lingering error before testing SkError. (Closed)

Created:
6 years, 3 months ago by mtklein_C
Modified:
6 years, 3 months ago
Reviewers:
humper, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Clear away any lingering error before testing SkError. Looks like something's setting an error before ErrorTest runs on our new Venue8 bots. BUG=skia: Committed: https://skia.googlesource.com/skia/+/fbe4136845fd68f583f9f9bfb628706c4b87480b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M tests/ErrorTest.cpp View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
mtklein
6 years, 3 months ago (2014-09-11 19:38:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/551973004/1
6 years, 3 months ago (2014-09-11 19:39:00 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 3 months ago (2014-09-11 19:39:01 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: Test-Android-Venue8-PowerVR-x86-Debug-Trybot on tryserver.skia (http://108.170.220.21:10117/builders/Test-Android-Venue8-PowerVR-x86-Debug-Trybot/builds/1)
6 years, 3 months ago (2014-09-11 21:40:43 UTC) #7
mtklein
I'm going to declare those test failures successes... they got past DM 2 for 2 ...
6 years, 3 months ago (2014-09-11 21:41:30 UTC) #8
mtklein
lgtm
6 years, 3 months ago (2014-09-11 21:41:46 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/551973004/1
6 years, 3 months ago (2014-09-11 21:41:52 UTC) #11
commit-bot: I haz the power
6 years, 3 months ago (2014-09-11 21:42:05 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as fbe4136845fd68f583f9f9bfb628706c4b87480b

Powered by Google App Engine
This is Rietveld 408576698