Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 551963003: Update the font preference for CJK (Closed)

Created:
6 years, 3 months ago by jungshik at Google
Modified:
6 years, 3 months ago
Reviewers:
Daniel Erat
CC:
jshin+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Update the font preference for CJK Noto Sans CJK {Japanese,Korean,Simplified Chinese,Traditional Chinese} are renamed Noto Sans CJK {JP,KR,SC,TC} to make their names future-proof (to work around the length restriction on another platform). We want to minimize the potential confusion (on the part of developers) due to this name change by adding the fonts with new names in the trunk and Chrome OS 38 branch asap. This CL will be landed along with the corresponding Chrome OS CL to actually update the font files and a Skia CL. Skia CL: https://codereview.chromium.org/554943002/ CrOS CL: https://chromium-review.googlesource.com/217290 BUG=412151 TEST=Once the fonts are updated on Chrome OS, Noto Sans CJK {SC,JP,KR} fonts are used in {zh,ja,ko}.wikipedia.org. They can be checked with DOM Inspector. TEST=`data:text/html,<span style="font-family:sans-serif;" lang="ja">&#x4E00;</span>` uses 'Noto Sans CJK JP`. TEST=Same as above with lang={ko,zh-CN,zh-TW} and font="Noto Sans CJK {KR,SC,TC}" as indicated in the DOM Inspector. Committed: https://crrev.com/7167ed1557aee86679706f8517e2b433a29325c3 Cr-Commit-Position: refs/heads/master@{#294294}

Patch Set 1 #

Patch Set 2 : bug number assigned, test added #

Patch Set 3 : update the descr/test/bug filed #

Total comments: 1

Messages

Total messages: 8 (2 generated)
jungshik at Google
This is protected for now because the actual update is supposed to be public on ...
6 years, 3 months ago (2014-09-09 18:53:31 UTC) #2
Daniel Erat
lgtm https://codereview.chromium.org/551963003/diff/40001/chrome/app/resources/locale_settings_chromiumos.grd File chrome/app/resources/locale_settings_chromiumos.grd (left): https://codereview.chromium.org/551963003/diff/40001/chrome/app/resources/locale_settings_chromiumos.grd#oldcode265 chrome/app/resources/locale_settings_chromiumos.grd:265: Noto Sans CJK Simplfieid Chinese heh, just noticed ...
6 years, 3 months ago (2014-09-09 19:05:08 UTC) #3
jungshik at Google
On 2014/09/09 19:05:08, Daniel Erat wrote: > lgtm > > https://codereview.chromium.org/551963003/diff/40001/chrome/app/resources/locale_settings_chromiumos.grd > File chrome/app/resources/locale_settings_chromiumos.grd (left): ...
6 years, 3 months ago (2014-09-09 23:47:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/551963003/40001
6 years, 3 months ago (2014-09-11 00:22:39 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001) as a478ad230ece76bf94427044d16fbaa435990b24
6 years, 3 months ago (2014-09-11 02:00:48 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-11 03:09:12 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/7167ed1557aee86679706f8517e2b433a29325c3
Cr-Commit-Position: refs/heads/master@{#294294}

Powered by Google App Engine
This is Rietveld 408576698