Chromium Code Reviews Chromium Code Reviews
Issue 551963002:
Add feedback for INLINE_METHOD refactoring. (Closed)
Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart| OLD | NEW |
|---|---|
| 1 <html> | 1 <html> |
| 2 <head> | 2 <head> |
| 3 <meta charset="UTF-8"/> | 3 <meta charset="UTF-8"/> |
| 4 <title>Analysis Server API Specification</title> | 4 <title>Analysis Server API Specification</title> |
| 5 </head> | 5 </head> |
| 6 <body> | 6 <body> |
| 7 <h1>Analysis Server API Specification</h1> | 7 <h1>Analysis Server API Specification</h1> |
| 8 <h1 style="color:#999999">WORKING DRAFT - Version <version>0.3</version></h1 > | 8 <h1 style="color:#999999">WORKING DRAFT - Version <version>0.3</version></h1 > |
| 9 <p> | 9 <p> |
| 10 This document contains a specification of the API provided by | 10 This document contains a specification of the API provided by |
| (...skipping 3162 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 3173 </refactoring> | 3173 </refactoring> |
| 3174 <refactoring kind="INLINE_METHOD"> | 3174 <refactoring kind="INLINE_METHOD"> |
| 3175 <p> | 3175 <p> |
| 3176 Inline a method in place of one or all references to that | 3176 Inline a method in place of one or all references to that |
| 3177 method. | 3177 method. |
| 3178 </p> | 3178 </p> |
| 3179 <p> | 3179 <p> |
| 3180 It is an error if the range contains anything other than all | 3180 It is an error if the range contains anything other than all |
| 3181 or part of the name of a single method. | 3181 or part of the name of a single method. |
| 3182 </p> | 3182 </p> |
| 3183 <feedback> | |
| 3184 <field name="className" optional="true"> | |
| 3185 <ref>String</ref> | |
| 3186 <p> | |
| 3187 The name of the class enclosing the method being inlined. | |
| 3188 If not a class member is being inlined, this field will be absent. | |
| 3189 </p> | |
| 3190 </field> | |
| 3191 <field name="methodName"> | |
| 3192 <ref>String</ref> | |
| 3193 <p> | |
| 3194 The name of the method (or function) being inlined. | |
| 3195 </p> | |
| 3196 </field> | |
| 3197 <field name="isDeclaration"> | |
| 3198 <ref>bool</ref> | |
| 3199 <p> | |
| 3200 True is the declaration of the method is selected. | |
|
Brian Wilkerson
2014/09/08 19:25:05
"True is" --> "True if"
| |
| 3201 So all references should be inlined. | |
| 3202 </p> | |
| 3203 </field> | |
| 3204 </feedback> | |
| 3183 <options> | 3205 <options> |
| 3184 <field name="deleteSource"> | 3206 <field name="deleteSource"> |
| 3185 <ref>bool</ref> | 3207 <ref>bool</ref> |
| 3186 <p> | 3208 <p> |
| 3187 True if the method being inlined should be removed. It | 3209 True if the method being inlined should be removed. |
| 3188 is an error if this field is true and inlineAll is | 3210 It is an error if this field is true and inlineAll is false. |
| 3189 false. | |
| 3190 </p> | 3211 </p> |
| 3191 </field> | 3212 </field> |
| 3192 <field name="inlineAll"> | 3213 <field name="inlineAll"> |
| 3193 <ref>bool</ref> | 3214 <ref>bool</ref> |
| 3194 <p> | 3215 <p> |
| 3195 True if all invocations of the method should be inlined, | 3216 True if all invocations of the method should be inlined, |
| 3196 or false if only the invocation site used to create this | 3217 or false if only the invocation site used to create this |
| 3197 refactoring should be inlined. | 3218 refactoring should be inlined. |
| 3198 </p> | 3219 </p> |
| 3199 </field> | 3220 </field> |
| (...skipping 53 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 3253 <h2>Errors</h2> | 3274 <h2>Errors</h2> |
| 3254 <p> | 3275 <p> |
| 3255 This section contains a list of all of the errors that are | 3276 This section contains a list of all of the errors that are |
| 3256 produced by the server and the data that is returned with each. | 3277 produced by the server and the data that is returned with each. |
| 3257 </p> | 3278 </p> |
| 3258 <p> | 3279 <p> |
| 3259 TBD | 3280 TBD |
| 3260 </p> | 3281 </p> |
| 3261 </body> | 3282 </body> |
| 3262 </html> | 3283 </html> |
| OLD | NEW |
