Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issue 551933002: Mark gtest and gmock as testonly in GN. (Closed)

Created:
6 years, 3 months ago by brettw
Modified:
6 years, 3 months ago
Reviewers:
jamesr, tfarina
CC:
chromium-reviews, qsr+mojo_chromium.org, zea+watch_chromium.org, viettrungluu+watch_chromium.org, browser-components-watch_chromium.org, yzshen+watch_chromium.org, ben+mojo_chromium.org, mkwst+watchlist_chromium.org, tim+watch_chromium.org, benquan, Ilya Sherman, jam, abarth-chromium, darin-cc_chromium.org, erikwright+watch_chromium.org, haitaol+watch_chromium.org, feature-media-reviews_chromium.org, piman+watch_chromium.org, gcasto+watchlist_chromium.org, rouslan+autofillwatch_chromium.org, maniscalco+watch_chromium.org, tfarina, Aaron Boodman, Dane Wallinga, dyu1, estade+watch_chromium.org, darin (slow to review), jln+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@testonly
Project:
chromium
Visibility:
Public.

Description

Committed: https://crrev.com/0c8745ab0e0a81fd627d6fcbf4569928724ff8c2 Cr-Commit-Position: refs/heads/master@{#293808}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : android #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -2 lines) Patch
M base/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M base/test/BUILD.gn View 1 1 chunk +2 lines, -1 line 0 comments Download
M breakpad/BUILD.gn View 3 chunks +3 lines, -1 line 0 comments Download
M build/secondary/testing/gmock/BUILD.gn View 1 2 chunks +4 lines, -0 lines 0 comments Download
M build/secondary/testing/gtest/BUILD.gn View 1 2 chunks +4 lines, -0 lines 0 comments Download
M components/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M components/auto_login_parser/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M components/autofill/content/browser/BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download
M components/autofill/core/browser/BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download
M components/autofill/core/common/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M components/bookmarks/browser/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M components/bookmarks/test/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M components/captive_portal/BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download
M components/cloud_devices/common/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M components/component_updater/BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download
M components/crx_file/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M components/data_reduction_proxy/common/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M components/dom_distiller/core/BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download
M components/domain_reliability/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M components/enhanced_bookmarks/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M components/gcm_driver/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M components/invalidation/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M components/omnibox/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M components/password_manager/content/renderer/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M components/password_manager/core/browser/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M components/policy/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M components/sessions/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M components/signin/core/browser/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M components/sync_driver/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M device/bluetooth/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M gin/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ipc/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M jingle/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M media/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M media/audio/BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download
M media/base/BUILD.gn View 3 chunks +3 lines, -0 lines 0 comments Download
M media/base/android/BUILD.gn View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M mojo/embedder/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/public/c/system/tests/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/public/cpp/test_support/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M sandbox/linux/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M sql/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M sync/BUILD.gn View 4 chunks +4 lines, -0 lines 0 comments Download
M ui/base/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ui/gl/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
brettw
6 years, 3 months ago (2014-09-08 17:04:05 UTC) #2
tfarina
ui/ lgtm
6 years, 3 months ago (2014-09-08 17:09:01 UTC) #4
jamesr
Have you run gn in the component build with this? The issue I'm worried about ...
6 years, 3 months ago (2014-09-08 17:59:08 UTC) #5
brettw
Okay, it now should work in component mode because I turned off the flag for ...
6 years, 3 months ago (2014-09-08 21:12:27 UTC) #6
jamesr
lgtm
6 years, 3 months ago (2014-09-08 21:16:50 UTC) #7
brettw
Committed patchset #3 (id:40001) to pending queue manually as 70149e8.
6 years, 3 months ago (2014-09-08 23:13:25 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:48:52 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/0c8745ab0e0a81fd627d6fcbf4569928724ff8c2
Cr-Commit-Position: refs/heads/master@{#293808}

Powered by Google App Engine
This is Rietveld 408576698