Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 551903002: Adds ability to disable connection pooling in QUIC. (Closed)

Created:
6 years, 3 months ago by Jana
Modified:
6 years, 3 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Adds ability to disable connection pooling in QUIC. BUG= Committed: https://crrev.com/584002d1c89e79223f8bf5f973294b96bdfa15ab Cr-Commit-Position: refs/heads/master@{#293823}

Patch Set 1 #

Patch Set 2 : Added connection pooling tests in quic_stream_factory_test #

Total comments: 2

Patch Set 3 : Nit addressed. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+245 lines, -1 line) Patch
M chrome/browser/io_thread.h View 1 2 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/io_thread.cc View 3 chunks +12 lines, -0 lines 0 comments Download
M chrome/browser/io_thread_unittest.cc View 1 2 2 chunks +11 lines, -0 lines 0 comments Download
M net/http/http_network_session.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/http/http_network_session.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M net/quic/quic_stream_factory.h View 2 chunks +4 lines, -0 lines 0 comments Download
M net/quic/quic_stream_factory.cc View 3 chunks +5 lines, -0 lines 0 comments Download
M net/quic/quic_stream_factory_test.cc View 1 5 chunks +205 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
Jana
6 years, 3 months ago (2014-09-08 17:31:17 UTC) #2
Ryan Hamilton
LGTM, though please rename the key... https://codereview.chromium.org/551903002/diff/20001/chrome/browser/io_thread_unittest.cc File chrome/browser/io_thread_unittest.cc (right): https://codereview.chromium.org/551903002/diff/20001/chrome/browser/io_thread_unittest.cc#newcode338 chrome/browser/io_thread_unittest.cc:338: field_trial_params_["DisableConnectionPooling"] = "true"; ...
6 years, 3 months ago (2014-09-08 17:39:15 UTC) #3
Jana
Fixed nit. Submitting. https://codereview.chromium.org/551903002/diff/20001/chrome/browser/io_thread_unittest.cc File chrome/browser/io_thread_unittest.cc (right): https://codereview.chromium.org/551903002/diff/20001/chrome/browser/io_thread_unittest.cc#newcode338 chrome/browser/io_thread_unittest.cc:338: field_trial_params_["DisableConnectionPooling"] = "true"; On 2014/09/08 17:39:15, ...
6 years, 3 months ago (2014-09-08 18:49:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jri@chromium.org/551903002/40001
6 years, 3 months ago (2014-09-08 18:51:23 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001) as 5e62d2e3377e9d75d1f4bc455a8cacce54a5cc90
6 years, 3 months ago (2014-09-09 00:52:22 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:49:19 UTC) #8
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/584002d1c89e79223f8bf5f973294b96bdfa15ab
Cr-Commit-Position: refs/heads/master@{#293823}

Powered by Google App Engine
This is Rietveld 408576698