Deactivate touch selection on transform

content/browser/renderer_host/render_widget_host_view_aura.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/renderer_host/render_widget_host_view_aura.h"
 
 #include "base/auto_reset.h"
 #include "base/basictypes.h"
 #include "base/bind.h"
 #include "base/callback_helpers.h"
@@ skipping 381 matching lines @@
 }
 
 // We have to implement the WindowObserver interface on a separate object
 // because clang doesn't like implementing multiple interfaces that have
 // methods with the same name. This object is owned by the
 // RenderWidgetHostViewAura.
 class RenderWidgetHostViewAura::WindowObserver : public aura::WindowObserver {
  public:
   explicit WindowObserver(RenderWidgetHostViewAura* view)
       : view_(view) {
-    view_->window_->AddObserver(this);
+    ObserveHierarchy(view_->window_);
   }
 
   virtual ~WindowObserver() {
-    view_->window_->RemoveObserver(this);
+    UnobserveHierarchy(view_->window_);
   }
 
   // Overridden from aura::WindowObserver:
+  virtual void OnWillRemoveWindow(aura::Window* window) OVERRIDE {
+    if (window->Contains(view_->window_))
+      UnobserveHierarchy(window->parent());
+  }
+
+  virtual void OnWindowParentChanged(aura::Window* window,
+                                     aura::Window* parent) OVERRIDE {
+    ObserveHierarchy(parent);
+  }
+
   virtual void OnWindowAddedToRootWindow(aura::Window* window) OVERRIDE {
     if (window == view_->window_)
       view_->AddedToRootWindow();
   }
 
   virtual void OnWindowRemovingFromRootWindow(aura::Window* window,
                                               aura::Window* new_root) OVERRIDE {
     if (window == view_->window_)
       view_->RemovingFromRootWindow();
   }
 
+  virtual void OnWindowTransformed(aura::Window* window) OVERRIDE {
+    if (view_->touch_editing_client_)
+      view_->touch_editing_client_->EndTouchEditing(true);
+  }
+
  private:
+  void ObserveHierarchy(aura::Window* window) {
+    for (; window; window = window->parent())

[sky, 2014/09/08 20:24:56]

This is going to be fragile and easy to get wrong. I think it better to change
aura to propagate transform changes to descendants. If you could do that in a
separate patch with test coverage that would be great.

[mohsen, 2014/09/09 21:36:36]

Isn't it going to be costly? E.g. if a transform is applied to the root window,
lots of windows are going to be notified. 

+      window->AddObserver(this);
+  }
+
+  void UnobserveHierarchy(aura::Window* window) {
+    for (; window; window = window->parent())
+      window->RemoveObserver(this);
+  }
+
   RenderWidgetHostViewAura* view_;
 
   DISALLOW_COPY_AND_ASSIGN(WindowObserver);
 };
 
 ////////////////////////////////////////////////////////////////////////////////
 // RenderWidgetHostViewAura, public:
 
 RenderWidgetHostViewAura::RenderWidgetHostViewAura(RenderWidgetHost* host)
     : host_(RenderWidgetHostImpl::From(host)),
@@ skipping 2062 matching lines @@
 
 ////////////////////////////////////////////////////////////////////////////////
 // RenderWidgetHostViewBase, public:
 
 // static
 void RenderWidgetHostViewBase::GetDefaultScreenInfo(WebScreenInfo* results) {
   GetScreenInfoForWindow(results, NULL);
 }
 
 }  // namespace content