Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Issue 551873003: Update DM JSON format. (Closed)

Created:
6 years, 3 months ago by mtklein_C
Modified:
6 years, 3 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Update DM JSON format. Ex. dm --match patch -w bad --key arch x86 gpu nvidia model z620 --properties git_hash abcd build_number 20 -> { "build_number" : "20", "git_hash" : "abcd", "key" : { "arch" : "x86", "gpu" : "nvidia", "model" : "z620" }, "results" : [ { "key" : { "config" : "565", "name" : "ninepatch-stretch" }, "md5" : "f78cfafcbabaf815f3dfcf61fb59acc7", "options" : { "source_type" : "GM" } }, { "key" : { "config" : "8888", "name" : "ninepatch-stretch" }, "md5" : "3e8a42f35a1e76f00caa191e6310d789", "options" : { "source_type" : "GM" } }, ... This breaks -r, but that's okay. Going to follow up this CL with one that removes that entirely. BUG=skia: Committed: https://skia.googlesource.com/skia/+/ea65bfa8ded918b908287e3e3474aaf5cbd12fea

Patch Set 1 #

Patch Set 2 : pretty #

Patch Set 3 : builder #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -34 lines) Patch
M bench/nanobench.cpp View 2 chunks +1 line, -6 lines 0 comments Download
M dm/DMCpuGMTask.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M dm/DMGpuGMTask.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M dm/DMPDFRasterizeTask.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M dm/DMPDFTask.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M dm/DMPipeTask.cpp View 1 chunk +1 line, -1 line 0 comments Download
M dm/DMQuiltTask.cpp View 1 chunk +1 line, -1 line 0 comments Download
M dm/DMSKPTask.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M dm/DMSerializeTask.cpp View 1 chunk +1 line, -1 line 0 comments Download
M dm/DMWriteTask.h View 1 2 3 2 chunks +8 lines, -6 lines 0 comments Download
M dm/DMWriteTask.cpp View 1 2 3 4 chunks +32 lines, -14 lines 0 comments Download
M tools/flags/SkCommonFlags.h View 1 chunk +3 lines, -0 lines 0 comments Download
M tools/flags/SkCommonFlags.cpp View 1 2 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
mtklein
6 years, 3 months ago (2014-09-08 20:29:47 UTC) #2
jcgregorio
On 2014/09/08 20:29:47, mtklein wrote: LGTM
6 years, 3 months ago (2014-09-09 12:56:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/551873003/60001
6 years, 3 months ago (2014-09-09 14:51:24 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-09-09 14:59:50 UTC) #6
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as ea65bfa8ded918b908287e3e3474aaf5cbd12fea

Powered by Google App Engine
This is Rietveld 408576698