Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 551863005: Added a WebRTC HD page to telemetry. (Closed)

Created:
6 years, 3 months ago by phoglund_chromium
Modified:
6 years, 2 months ago
Reviewers:
qyearsley
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Added a WebRTC HD measurement. This test measures CPU and memory when we acquire a HD stream with WebRTC. The existing local-video.html demo will acquire whatever is the default, which currently is VGA. The demo page is taken from our GitHub demo repository and is only lightly edited to get js paths right. BUG=413577 Committed: https://crrev.com/01f80ea68b50db5110b2c97974e0969f17a7c6c9 Cr-Commit-Position: refs/heads/master@{#296700}

Patch Set 1 #

Patch Set 2 : Instead, downloading page using wpr. #

Patch Set 3 : #

Total comments: 4

Patch Set 4 : Removed endure methods. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -5 lines) Patch
A tools/perf/page_sets/data/webrtc_cases.json View 1 1 chunk +10 lines, -0 lines 0 comments Download
A tools/perf/page_sets/data/webrtc_cases_000.wpr.sha1 View 1 1 chunk +1 line, -0 lines 0 comments Download
M tools/perf/page_sets/webrtc_cases.py View 1 2 3 2 chunks +15 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
phoglund_chromium
6 years, 3 months ago (2014-09-12 10:44:07 UTC) #2
qyearsley
LGTM, although I want to confirm that this is what we want to do with ...
6 years, 3 months ago (2014-09-23 17:01:35 UTC) #3
phoglund_chromium
https://codereview.chromium.org/551863005/diff/40001/tools/perf/page_sets/webrtc_cases.py File tools/perf/page_sets/webrtc_cases.py (right): https://codereview.chromium.org/551863005/diff/40001/tools/perf/page_sets/webrtc_cases.py#newcode64 tools/perf/page_sets/webrtc_cases.py:64: action_runner.Wait(10) Yeah, I double-checked and nobody calls RunEndure anymore, ...
6 years, 3 months ago (2014-09-25 11:31:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/551863005/60001
6 years, 3 months ago (2014-09-25 11:32:57 UTC) #6
commit-bot: I haz the power
Committed patchset #4 (id:60001) as bcb3d20d9242fe6d919f2296eff9ef7a945ad6b8
6 years, 2 months ago (2014-09-25 12:28:39 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-09-25 12:29:17 UTC) #8
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/01f80ea68b50db5110b2c97974e0969f17a7c6c9
Cr-Commit-Position: refs/heads/master@{#296700}

Powered by Google App Engine
This is Rietveld 408576698