tools/gn/target.cc - Issue 551843006: GN: fix datadeps visibility check

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/target.cc

Issue 551843006: GN: fix datadeps visibility check (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/gn/target.cc

diff --git a/tools/gn/target.cc b/tools/gn/target.cc

index ba1e4b780610c995e49be094804a1d665c20290c..dc2d9e156cec3dc9e713cf09e7f74518aedebbc5 100644

--- a/tools/gn/target.cc

+++ b/tools/gn/target.cc

@@ -362,7 +362,7 @@ bool Target::CheckVisibility(Err* err) const {

}

for (size_t i = 0; i < datadeps_.size(); i++) {

- if (deps_[i].origin &&

+ if (datadeps_[i].origin &&

!Visibility::CheckItemVisibility(this, datadeps_[i].ptr, err))

return false;

}

« no previous file with comments | « no previous file | tools/gn/target_unittest.cc » ('j') | no next file with comments »