Issue 551843005: [ServiceWorkr] Add NULL check of provider_host_ in ServiceWorkerControlleeRequestHandler's callbacks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 551843005: [ServiceWorkr] Add NULL check of provider_host_ in ServiceWorkerControlleeRequestHandler's callbacks (Closed)

Created:
6 years, 3 months ago by horo

Modified:
6 years, 3 months ago

Reviewers:
dominicc (has gone to gerrit)

CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, serviceworker-reviews, tzik, mkwst+moarreviews-content_chromium.org, jam, darin-cc_chromium.org, horo+watch_chromium.org, kinuko+serviceworker

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

[ServiceWorkr] Add NULL check of provider_host_ in ServiceWorkerControlleeRequestHandler's callback methods. WeakPtr<ServiceWorkerProviderHost> provider_host_ could be NULL when these methods are called. BUG=408880, 414170

Patch Set 1 #

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -5 lines)			Patch
	M	content/browser/service_worker/service_worker_controllee_request_handler.cc	View		5 chunks	+10 lines, -5 lines	0 comments	Download

Messages

Total messages: 6 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

horo

dominicc@ Could you please review this? http://crbug.com/414170 may be fixed by this patch.

6 years, 3 months ago (2014-09-16 01:24:03 UTC) #3

nhiroki

michaeln@ is now committing the similar patch (https://codereview.chromium.org/569423002/)

6 years, 3 months ago (2014-09-16 01:30:50 UTC) #4

dominicc (has gone to gerrit)

In future an early return may make sense here but for now LGTM.

6 years, 3 months ago (2014-09-16 01:32:23 UTC) #5

horo

6 years, 3 months ago (2014-09-16 01:33:13 UTC) #6

On 2014/09/16 01:30:50, nhiroki wrote:
> michaeln@ is now committing the similar patch
> (https://codereview.chromium.org/569423002/)

Ah. Yes.
I didn't notice this.
Thank you.
I will close this.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages