chrome/browser/sync/profile_sync_service.h - Issue 551843003: Persist Directory to disk when the app is backgrounded.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/profile_sync_service.h

Issue 551843003: Persist Directory to disk when the app is backgrounded. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add a test and use SyncBackendHostCore::SaveChanges(). Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/sync/glue/sync_backend_host_core.cc ('K') | « chrome/browser/sync/glue/sync_backend_host_mock.cc ('k') | chrome/browser/sync/profile_sync_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync/profile_sync_service.h

diff --git a/chrome/browser/sync/profile_sync_service.h b/chrome/browser/sync/profile_sync_service.h

index ac43cf81ce786167549950f3862336c359599b35..9c751fd4874509ed1a2c5bb03e239bdfe4d68b43 100644

--- a/chrome/browser/sync/profile_sync_service.h

+++ b/chrome/browser/sync/profile_sync_service.h

@@ -781,6 +781,11 @@ class ProfileSyncService : public ProfileSyncServiceBase,

base::Time GetDeviceBackupTimeForTesting() const;

+ // This triggers a Directory::SaveChanges() call on the sync thread.

+ // It should be used to persist data to disk when the process might be

+ // killed in the near future.

+ void FlushDirectory() const;

protected:

// Helper to configure the priority data types.

void ConfigurePriorityDataTypes();