runtime/vm/method_recognizer.h - Issue 551823002: Optimize _GrowableArray._join and _StringBase._interpolate.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/method_recognizer.h

Issue 551823002: Optimize _GrowableArray._join and _StringBase._interpolate. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Don't optimize one/two length interpolations (other CL does the one-case better) Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/method_recognizer.h

diff --git a/runtime/vm/method_recognizer.h b/runtime/vm/method_recognizer.h

index 653c0ef22b25728b5886320bb0e44de073921e22..abb22d5e0ab19ff10c19680afde782be1de2e403 100644

--- a/runtime/vm/method_recognizer.h

+++ b/runtime/vm/method_recognizer.h

@@ -37,7 +37,7 @@ namespace dart {

V(_TypedList, _setFloat64, ByteArrayBaseSetFloat64, 972883980) \

V(_TypedList, _setFloat32x4, ByteArrayBaseSetFloat32x4, 950522310) \

V(_TypedList, _setInt32x4, ByteArrayBaseSetInt32x4, 1301138078) \

- V(_StringBase, _interpolate, StringBaseInterpolate, 1758627989) \

+ V(_StringBase, _interpolate, StringBaseInterpolate, 2070743748) \

V(_IntegerImplementation, toDouble, IntegerToDouble, 1084977108) \

V(_IntegerImplementation, _leftShiftWithMask32, IntegerLeftShiftWithMask32, \

597111055) \

« runtime/lib/string_patch.dart ('K') | « runtime/lib/string_patch.dart ('k') | no next file » | no next file with comments »