Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 551803006: Clean up logging for debugging RAF related flakiness in WebGL conformance tests. (Closed)

Created:
6 years, 3 months ago by Zhenyao Mo
Modified:
6 years, 3 months ago
CC:
chromium-reviews, darin-cc_chromium.org, cc-bugs_chromium.org, jam, piman+watch_chromium.org, mkwst+moarreviews-content_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Clean up logging for debugging RAF related flakiness in WebGL conformance tests. We figured out which part caused the problom, so these logs are no longer needed. BUG=393331 TEST=bots TBR=kbr@chromium.org Committed: https://crrev.com/006c99bdb5c9940a8263acd77be93f93e5727b28 Cr-Commit-Position: refs/heads/master@{#294937}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -17 lines) Patch
M cc/trees/thread_proxy.cc View 9 chunks +0 lines, -16 lines 0 comments Download
M content/renderer/gpu/render_widget_compositor.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/551803006/1
6 years, 3 months ago (2014-09-15 20:05:33 UTC) #2
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/66980) mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/56113) android_arm64_dbg_recipe ...
6 years, 3 months ago (2014-09-15 20:22:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/551803006/1
6 years, 3 months ago (2014-09-15 22:39:35 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as a7db99c312d7ee793d98082a93aa2efed38f2868
6 years, 3 months ago (2014-09-16 00:17:24 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/006c99bdb5c9940a8263acd77be93f93e5727b28 Cr-Commit-Position: refs/heads/master@{#294937}
6 years, 3 months ago (2014-09-16 00:20:58 UTC) #8
Ken Russell (switch to Gerrit)
LGTM, though I wonder if we should have just turned off the logging in the ...
6 years, 3 months ago (2014-09-16 01:06:22 UTC) #9
danakj
6 years, 3 months ago (2014-09-16 01:09:51 UTC) #10
On Mon, Sep 15, 2014 at 9:06 PM, <kbr@chromium.org> wrote:

> LGTM, though I wonder if we should have just turned off the logging in the
> GPU
> recipe for the next time an issue in this area crops up. (Not sure whether
> these
> logs had any run-time cost in Release builds -- can't imagine they would.)
>
They're strings that cost us binary size. We should remove them or put them
inside DEBUG only macros.


>
>
> https://codereview.chromium.org/551803006/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698