src/x64/lithium-x64.cc - Issue 551803005: The value register in storefield(smi) is not used as a temp

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/lithium-x64.cc

Issue 551803005: The value register in storefield(smi) is not used as a temp (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/x64/lithium-x64.cc

diff --git a/src/x64/lithium-x64.cc b/src/x64/lithium-x64.cc

index b7b13867d364db65ae469f54f6b2e7e997ed851f..815038b9e699d2fa053f8c9b912da22e9045166b 100644

--- a/src/x64/lithium-x64.cc

+++ b/src/x64/lithium-x64.cc

@@ -2398,8 +2398,6 @@ LInstruction* LChunkBuilder::DoStoreNamedField(HStoreNamedField* instr) {

val = UseFixed(instr->value(), rax);

} else if (can_be_constant) {

val = UseRegisterOrConstant(instr->value());

- } else if (instr->field_representation().IsSmi()) {

- val = UseRegister(instr->value());

} else if (instr->field_representation().IsDouble()) {

val = UseRegisterAtStart(instr->value());

} else {

« no previous file with comments | « src/mips64/lithium-mips64.cc ('k') | src/x87/lithium-x87.cc » ('j') | no next file with comments »