Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Side by Side Diff: src/ia32/lithium-ia32.cc

Issue 551803005: The value register in storefield(smi) is not used as a temp (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm/lithium-arm.cc ('k') | src/mips/lithium-mips.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_IA32 7 #if V8_TARGET_ARCH_IA32
8 8
9 #include "src/hydrogen-osr.h" 9 #include "src/hydrogen-osr.h"
10 #include "src/ia32/lithium-codegen-ia32.h" 10 #include "src/ia32/lithium-codegen-ia32.h"
(...skipping 2396 matching lines...) Expand 10 before | Expand all | Expand 10 after
2407 LOperand* val; 2407 LOperand* val;
2408 if (instr->field_representation().IsInteger8() || 2408 if (instr->field_representation().IsInteger8() ||
2409 instr->field_representation().IsUInteger8()) { 2409 instr->field_representation().IsUInteger8()) {
2410 // mov_b requires a byte register (i.e. any of eax, ebx, ecx, edx). 2410 // mov_b requires a byte register (i.e. any of eax, ebx, ecx, edx).
2411 // Just force the value to be in eax and we're safe here. 2411 // Just force the value to be in eax and we're safe here.
2412 val = UseFixed(instr->value(), eax); 2412 val = UseFixed(instr->value(), eax);
2413 } else if (needs_write_barrier) { 2413 } else if (needs_write_barrier) {
2414 val = UseTempRegister(instr->value()); 2414 val = UseTempRegister(instr->value());
2415 } else if (can_be_constant) { 2415 } else if (can_be_constant) {
2416 val = UseRegisterOrConstant(instr->value()); 2416 val = UseRegisterOrConstant(instr->value());
2417 } else if (instr->field_representation().IsSmi()) {
2418 val = UseTempRegister(instr->value());
2419 } else if (instr->field_representation().IsDouble()) { 2417 } else if (instr->field_representation().IsDouble()) {
2420 val = UseRegisterAtStart(instr->value()); 2418 val = UseRegisterAtStart(instr->value());
2421 } else { 2419 } else {
2422 val = UseRegister(instr->value()); 2420 val = UseRegister(instr->value());
2423 } 2421 }
2424 2422
2425 // We only need a scratch register if we have a write barrier or we 2423 // We only need a scratch register if we have a write barrier or we
2426 // have a store into the properties array (not in-object-property). 2424 // have a store into the properties array (not in-object-property).
2427 LOperand* temp = (!is_in_object || needs_write_barrier || 2425 LOperand* temp = (!is_in_object || needs_write_barrier ||
2428 needs_write_barrier_for_map) ? TempRegister() : NULL; 2426 needs_write_barrier_for_map) ? TempRegister() : NULL;
(...skipping 286 matching lines...) Expand 10 before | Expand all | Expand 10 after
2715 LOperand* function = UseRegisterAtStart(instr->function()); 2713 LOperand* function = UseRegisterAtStart(instr->function());
2716 LAllocateBlockContext* result = 2714 LAllocateBlockContext* result =
2717 new(zone()) LAllocateBlockContext(context, function); 2715 new(zone()) LAllocateBlockContext(context, function);
2718 return MarkAsCall(DefineFixed(result, esi), instr); 2716 return MarkAsCall(DefineFixed(result, esi), instr);
2719 } 2717 }
2720 2718
2721 2719
2722 } } // namespace v8::internal 2720 } } // namespace v8::internal
2723 2721
2724 #endif // V8_TARGET_ARCH_IA32 2722 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/arm/lithium-arm.cc ('k') | src/mips/lithium-mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698