Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issue 551753002: ONC: Remove augmentation of unmanaged network properties. (Closed)

Created:
6 years, 3 months ago by pneubeck (no reviews)
Modified:
6 years, 3 months ago
Reviewers:
stevenjb
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, oshima+watch_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@ipconfig
Project:
chromium
Visibility:
Public.

Description

ONC: Remove augmentation of unmanaged network properties. Before read-only properties which cannot be set by the user or policy, were explicitly marked as 'unmanaged' in the augmented dictionary returned by getManagedProperties. Now, instead these properties are returned as plain values, which simplifies the consumer side, especially of Array typed properties like IPConfigs (compare this with SavedIPConfig). BUG=410877 Committed: https://crrev.com/49d77fc25ca944fcfb4a1e39862483656e208f85 Cr-Commit-Position: refs/heads/master@{#293931}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -113 lines) Patch
M chrome/test/data/extensions/api_test/networking/test.js View 3 chunks +5 lines, -20 lines 0 comments Download
M chromeos/network/onc/onc_merger.cc View 1 chunk +63 lines, -62 lines 0 comments Download
M chromeos/test/data/network/augmented_merge.json View 1 chunk +8 lines, -29 lines 0 comments Download
M components/onc/onc_constants.h View 1 chunk +0 lines, -1 line 0 comments Download
M components/onc/onc_constants.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
pneubeck (no reviews)
This is the follow-up to the IPConfig change and simplifies the getManagedProperties dictionary for read-only/unmanaged ...
6 years, 3 months ago (2014-09-08 08:38:02 UTC) #2
stevenjb
Hooray, I think this will make Managed ONC much more maintainable, thanks. LGTM
6 years, 3 months ago (2014-09-08 16:59:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pneubeck@chromium.org/551753002/1
6 years, 3 months ago (2014-09-08 21:56:54 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/64159) mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/53180) win_gpu ...
6 years, 3 months ago (2014-09-09 02:14:30 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pneubeck@chromium.org/551753002/1
6 years, 3 months ago (2014-09-09 11:06:16 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1) as 7a69be0488e893c690ef288bc1540468f1c4b5c2
6 years, 3 months ago (2014-09-09 13:19:45 UTC) #11
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:53:07 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/49d77fc25ca944fcfb4a1e39862483656e208f85
Cr-Commit-Position: refs/heads/master@{#293931}

Powered by Google App Engine
This is Rietveld 408576698