Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 551723003: Subzero: Make python clean up after itself by removing its /tmp subdir. (Closed)

Created:
6 years, 3 months ago by Jim Stichnoth
Modified:
6 years, 3 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Import errno for good measure #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -13 lines) Patch
M pydir/build-pnacl-ir.py View 1 2 chunks +22 lines, -13 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Jim Stichnoth
6 years, 3 months ago (2014-09-15 21:22:41 UTC) #2
jvoung (off chromium)
otherwise LGTM https://codereview.chromium.org/551723003/diff/1/pydir/build-pnacl-ir.py File pydir/build-pnacl-ir.py (right): https://codereview.chromium.org/551723003/diff/1/pydir/build-pnacl-ir.py#newcode45 pydir/build-pnacl-ir.py:45: if exc.errno != errno.ENOENT: # ENOENT - ...
6 years, 3 months ago (2014-09-15 21:36:17 UTC) #3
Jim Stichnoth
https://codereview.chromium.org/551723003/diff/1/pydir/build-pnacl-ir.py File pydir/build-pnacl-ir.py (right): https://codereview.chromium.org/551723003/diff/1/pydir/build-pnacl-ir.py#newcode45 pydir/build-pnacl-ir.py:45: if exc.errno != errno.ENOENT: # ENOENT - no such ...
6 years, 3 months ago (2014-09-15 21:52:10 UTC) #4
Jim Stichnoth
6 years, 3 months ago (2014-09-16 17:22:30 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as e8b404b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698