Fix handling default parameters

tools/dom/scripts/idlnode.py

 #!/usr/bin/python
 # Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 # for details. All rights reserved. Use of this source code is governed by a
 # BSD-style license that can be found in the LICENSE file.
 
 import os
 import sys
 
 import idl_definitions
 from idl_types import IdlType, IdlUnionType
@@ skipping 601 matching lines @@
       IDLParentInterface)
 
     javascript_interface_name = self.ext_attrs.get('InterfaceName', self.id)
     self.javascript_binding_name = javascript_interface_name
     self.doc_js_name = javascript_interface_name
 
     if not (self._find_first(ast, 'Callback') is None):
       self.ext_attrs['Callback'] = None
     if not (self._find_first(ast, 'Partial') is None):
       self.is_supplemental = True
-      self.ext_attrs['Supplemental'] = None
+      self.ext_attrs['DartSupplemental'] = None
 
     self.operations = self._convert_all(ast, 'Operation',
       lambda ast: IDLOperation(ast, self.doc_js_name))
     self.attributes = self._convert_all(ast, 'Attribute',
       lambda ast: IDLAttribute(ast, self.doc_js_name))
     self.constants = self._convert_all(ast, 'Const',
       lambda ast: IDLConstant(ast, self.doc_js_name))
-    self.is_supplemental = 'Supplemental' in self.ext_attrs
+    self.is_supplemental = 'DartSupplemental' in self.ext_attrs
     self.is_no_interface_object = 'NoInterfaceObject' in self.ext_attrs
     # TODO(terry): Can eliminate Suppressed when we're only using blink parser.
     self.is_fc_suppressed = 'Suppressed' in self.ext_attrs or \
                             'DartSuppress' in self.ext_attrs
 
 
   def reset_id(self, new_id):
     """Reset the id of the Interface and corresponding the JS names."""
     if self.id != new_id:
       self.id = new_id
@@ skipping 47 matching lines @@
     self.type = self._convert_first(ast, 'ReturnType', IDLType)
     self.arguments = self._convert_all(ast, 'Argument', IDLArgument)
     self.specials = self._find_all(ast, 'Special')
     # Special case: there are getters of the form
     # getter <ReturnType>(args).  For now force the name to be __getter__,
     # but it should be operator[] later.
     if self.id is None:
       if self.specials == ['getter']:
         if self.ext_attrs.get('Custom') == 'PropertyQuery':
           # Handling __propertyQuery__ the extended attribute is:
-          # [Custom=PropertyQuery] legacycaller boolean (DOMString name);
+          # [Custom=PropertyQuery] getter boolean (DOMString name);
           self.id = '__propertyQuery__'
         else:
           self.id = '__getter__'
       elif self.specials == ['setter']:
         self.id = '__setter__'
         # Special case: if it's a setter, ignore 'declared' return type
         self.type = IDLType([('VoidType', None)])
       elif self.specials == ['deleter']:
         self.id = '__delete__'
       else:
@@ skipping 29 matching lines @@
   """IDLNode specialization for 'const type name = value' declarations."""
   def __init__(self, ast, doc_js_interface_name):
     IDLMember.__init__(self, ast, doc_js_interface_name)
     self.value = self._find_first(ast, 'ConstExpr')
 
 
 class IDLArgument(IDLNode):
   """IDLNode specialization for operation arguments."""
   def __init__(self, ast):
     IDLNode.__init__(self, ast)
+
+    self.default_value = None
+    self.default_value_is_null = False
+    # Handle the 'argType arg = default'. IDL syntax changed from
+    # [default=NullString].
+    if not isinstance(ast, list):
+      if isinstance(ast.default_value, idl_definitions.IdlLiteral) and ast.default_value:
+        self.default_value = ast.default_value.value
+        self.default_value_is_null = ast.default_value.is_null
+      elif 'Default' in ast.extended_attributes:
+        # Work around [Default=Undefined] for arguments - only look in the model's
+        # default_value
+        self.default_value = ast.extended_attributes.get('Default')
+        self.default_value_is_null = False
+
     self.type = self._convert_first(ast, 'Type', IDLType)
     self.optional = self._has(ast, 'Optional')
     self._convert_ext_attrs(ast)
     # TODO(vsm): Recover this from the type instead.
     if 'Callback' in self.type.id:
       self.ext_attrs['Callback'] = None
 
   def __repr__(self):
     return '<IDLArgument(type = %s, id = %s)>' % (self.type, self.id)
 
@@ skipping 24 matching lines @@
   """IDLDictNode specialization for one annotation."""
   def __init__(self, ast=None):
     IDLDictNode.__init__(self, ast)
     self.id = None
     if not ast:
       return
     for arg in self._find_all(ast, 'AnnotationArg'):
       name = self._find_first(arg, 'Id')
       value = self._find_first(arg, 'AnnotationArgValue')
       self[name] = value